ACK to the series: * applies clean, I tested against ec2 driver works well
* wondering if we should make ipv4 an explicit 'type' (i.e. currently if it's not :mac, :hostname etc, its implied type is ipv4) * InstanceAddress is an 'internal' model - i.e. its not exposed as a top level collection - which means we don't need to add a new section to the API docs ... but * probably we should update the docs on 'Instances' in the API, to explain the 'types' of addresses the client can expect, marios On 02/11/11 16:05, mfoj...@redhat.com wrote: > Hi, > > This patchset introduce a new model 'InstanceAddress' for storing and > manipulating with all different address types we need to deal across > cloud providers. > Previously we have some sort of 'address' type guessing which fails > in most cases and caused a lot of confusion with VNC ports and so. > > Currently we have five types of addresses in instance: > > 1) :ipv6 - Indicate that address is given in IPv6 format (127.0.0.1) > 2) :mac - Address contain a MAC address of the instance NIC adapter > 3) :hostname - Address is reported in 'hostname' format (inst0.example.com) > 4) :vnc - Address points to VNC server. Optionally a port attribute is > specified > 5) :unavailable - Address is currently unavailable (case when instance is > booting / or no address is available 'yet') > > Client code should be already compatible with this XML format: > > <public_addresses> > <address type="vnc" port="3001">10.0.0.1</address> > <address type="ipv6">1.1.1.1</address> > </public_addresses> > > -- Michal >
