minor issue with nesting of MachineConfiguration attributes, otherwise, ACK:
On 16/11/11 22:34, mfoj...@redhat.com wrote:
> From: Michal Fojtik <mfoj...@redhat.com>
>
> class CIMI::Model::MachineConfiguration < CIMI::Model::Base
>
> - array :disk do
> - scalar :capacity
> + array :disks do
> + struct :capacity do
> + scalar :format
> + scalar :quantity
> + scalar :attachment_point
> + scalar :units
> + end
> end
should be:
array :disks do
struct :capacity do
scalar :quantity
scalar :units
end
scalar :format
scalar :attachment_point
end
i.e. :quantity and :units are nested attributes of :capacity but :format
and :attachment_point are direct attributes of each :disk
>
> array :operations do
> diff --git a/server/lib/cimi/model/machine_image.rb
> b/server/lib/cimi/model/machine_image.rb
> index a23638f..18d91d4 100644
> --- a/server/lib/cimi/model/machine_image.rb
> +++ b/server/lib/cimi/model/machine_image.rb
> @@ -15,7 +15,7 @@
>
> class CIMI::Model::MachineImage < CIMI::Model::Base
>
> - scalar :image_location
> + href :image_location
> text :image_data
>
> array :operations do
