[deltacloud-devel] [PATCH core 4/9] Error handling: remove safely and catch_auth from DriverHelper

[lutter]

From: David Lutterkort <lut...@redhat.com>

  * catch_auth was only used in the Rails controllers, but nowhere in the
    Sinatra version
  * safely was producing output when it shouldn't; error handling should be
    left to the toplevel server control
---
 server/lib/deltacloud/helpers/driver_helper.rb |   19 ------------
 server/server.rb                               |   36 ++++++++++--------------
 2 files changed, 15 insertions(+), 40 deletions(-)

diff --git a/server/lib/deltacloud/helpers/driver_helper.rb 
b/server/lib/deltacloud/helpers/driver_helper.rb
index f1235d5..352253f 100644
--- a/server/lib/deltacloud/helpers/driver_helper.rb
+++ b/server/lib/deltacloud/helpers/driver_helper.rb
@@ -26,23 +26,4 @@ module DriverHelper
       Converters::XMLConverter.new( self, type ).convert(obj)
     end
   end
-
-  def catch_auth
-    begin
-      yield
-    rescue Deltacloud::AuthException => e
-      authenticate_or_request_with_http_basic() do |n,p|
-      end
-    end
-  end
-
-  def safely(&block)
-    begin
-      block.call
-    rescue Deltacloud::AuthException => e
-      @response.status=403
-      "<error>#{e.message}</error>"
-    end
-  end
-
 end
diff --git a/server/server.rb b/server/server.rb
index 0c1755e..675658e 100644
--- a/server/server.rb
+++ b/server/server.rb
@@ -42,25 +42,21 @@ def filter_all(model)
     filter.merge!(:owner_id => params[:owner_id]) if params[:owner_id]
     filter.merge!(:state => params[:state]) if params[:state]
     filter = nil if filter.keys.size.eql?(0)
-    safely do
-      singular = model.to_s.singularize.to_sym
-      @elements = driver.send(model.to_sym, credentials, filter)
-      instance_variable_set(:"@#{model}", @elements)
-      respond_to do |format|
-        format.xml  { return convert_to_xml(singular, @elements) }
-        format.html { haml :"#{model}/index" }
-      end
+    singular = model.to_s.singularize.to_sym
+    @elements = driver.send(model.to_sym, credentials, filter)
+    instance_variable_set(:"@#{model}", @elements)
+    respond_to do |format|
+      format.xml  { return convert_to_xml(singular, @elements) }
+      format.html { haml :"#{model}/index" }
     end
 end
 
 def show(model)
-  safely do
-    @element = driver.send(model, credentials, { :id => params[:id]} )
-    instance_variable_set("@#{model}", @element)
-    respond_to do |format|
-      format.xml { return convert_to_xml(model, @element) }
-      format.html { haml :"#{model.to_s.pluralize}/show" }
-    end
+  @element = driver.send(model, credentials, { :id => params[:id]} )
+  instance_variable_set("@#{model}", @element)
+  respond_to do |format|
+    format.xml { return convert_to_xml(model, @element) }
+    format.html { haml :"#{model.to_s.pluralize}/show" }
   end
 end
 
@@ -209,12 +205,10 @@ get "/api/instances/new" do
 end
 
 def instance_action(name)
-  safely do
-    @instance = driver.send(:"#{name}_instance", credentials, params[:id])
-    respond_to do |format|
-      format.xml { return convert_to_xml(:instance, @instance) }
-      format.html { haml :"instances/show" }
-    end
+  @instance = driver.send(:"#{name}_instance", credentials, params[:id])
+  respond_to do |format|
+    format.xml { return convert_to_xml(:instance, @instance) }
+    format.html { haml :"instances/show" }
   end
 end
 
-- 
1.6.6.1

_______________________________________________
deltacloud-devel mailing list
deltacloud-devel@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/deltacloud-devel