On 03/11/2010 05:28 PM, Jason Guiditta wrote:
> This patch takes the first step in getting the
> design closer to what Jeremy has in his mockups.
>
> There will be significant overall changes that
> will have an entire separate css patch later, so
> I ignored things like having the 'cancel' link
> lined up under the form buttons. However, form
> layout should be more consistent to support
> upcoming changes.
>
> cucumber tests should now pass.
> ---
> src/app/views/user_sessions/new.html.erb | 32 +++++++++++++++----------
> src/app/views/users/_form.erb | 36
> +++++++++++++++++++++--------
> src/app/views/users/edit.html.erb | 11 ++++-----
> src/app/views/users/new.html.erb | 9 ++++---
> src/app/views/users/show.html.erb | 2 +-
> src/public/stylesheets/dcloud.css | 9 +++----
> 6 files changed, 60 insertions(+), 39 deletions(-)
>
> diff --git a/src/app/views/user_sessions/new.html.erb
> b/src/app/views/user_sessions/new.html.erb
> index ee7da51..92f384c 100644
> --- a/src/app/views/user_sessions/new.html.erb
> +++ b/src/app/views/user_sessions/new.html.erb
> @@ -1,18 +1,24 @@
> -<div class="dcloud_form">
> -<h2>Login</h2>
> +<h2 class="greeting">Welcome to $aggregator. Please sign in.</h2>
>
This entire patch looks good / works as expected but I was just
wondering about the '$' before the word 'aggregator', it is pretty
noticeably out of place in the UI. Other than that ACK.
-Mo
_______________________________________________
deltacloud-devel mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/deltacloud-devel
