On Fri, 2010-03-26 at 09:12 +0100, Michal Fojtik wrote:
> On 25/03/10 15:40 -0700, David Lutterkort wrote:
> >On Wed, 2010-03-24 at 15:54 +0100, [email protected] wrote:
> >> ---
> >>  server/support/fedora/deltacloudd           |  106 
> >> +++++++++++++++++++++++++++
> >>  server/support/fedora/sysconfig_deltacloudd |    8 ++
> >>  2 files changed, 114 insertions(+), 0 deletions(-)
> >>  create mode 100755 server/support/fedora/deltacloudd
> >>  create mode 100644 server/support/fedora/sysconfig_deltacloudd
> >
> >Initscript looks fine, one question about sysconfig setup:
> >
> >> diff --git a/server/support/fedora/sysconfig_deltacloudd 
> >> b/server/support/fedora/sysconfig_deltacloudd
> >> new file mode 100644
> >> index 0000000..3f8fe91
> >> --- /dev/null
> >> +++ b/server/support/fedora/sysconfig_deltacloudd
> >> @@ -0,0 +1,8 @@
> >> +# Driver to use
> >> +API_DRIVER="mock"
> >> +# API port for accepting HTTP requests
> >> +API_PORT="3001"
> >> +# API host
> >> +API_HOST="localhost"
> >> +# Environment (production or development)
> >> +API_ENVIRONMENT="production"
> >
> >Is there really a point in configuring the environment ? I have a hard
> >time believing that anybody wants to run a dev or test instance from the
> >initscript.
> 
> Of course, there is no real point other than that user want's to have more
> details in log / raise errors / etc. This could be set to production.

Sure - for those though it would be better to have specific settings,
rather than switching the environment wholesale. I don't think we need
to add that for now; I'd only do that if we had a clear need for that.

David


_______________________________________________
deltacloud-devel mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/deltacloud-devel

Reply via email to