On Tue, 2010-05-11 at 14:55 +0100, [email protected] wrote:
> From: marios <[email protected]>
>
> ---
> .../drivers/terremark/terremark_driver.rb | 261
> ++++++++++++++++++++
> server/lib/drivers.rb | 11 +-
> 2 files changed, 263 insertions(+), 9 deletions(-)
> create mode 100644
> server/lib/deltacloud/drivers/terremark/terremark_driver.rb
ACK. There's acouple minor nits: one is that there is a lot of trailing
whitespace that you should remove (I can send you Emacs macros that do
that automatically)
The other issue is
> diff --git a/server/lib/drivers.rb b/server/lib/drivers.rb
> index 1add916..269fe75 100644
> --- a/server/lib/drivers.rb
> +++ b/server/lib/drivers.rb
>
> @@ -27,15 +28,7 @@ def driver_mock_source_name
> end
>
> def driver
> -
> - begin
> - require driver_source_name
> - rescue LoadError => e
> - gem_name = e.message.match(/ -- (.+)$/).to_a.last
> - gem_name = "amazon-ec2" if gem_name.eql?('AWS')
> - $stderr.puts "ERROR: Please install required gem first. (gem install
> #{gem_name})"
> - exit 1
> - end
> + require driver_source_name
Leave the rescue in there - that's the central place to catch LoadError
that I was talking about. Michal: is there a way to put this even
higher, into deltacloudd or is it too hard to catch the error there ?
David
_______________________________________________
deltacloud-devel mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/deltacloud-devel
