Hi David,
On 18/05/10 00:43, David Lutterkort wrote:
>> > * Issue with the way credentials were being used which caused thin to
>> > explode ('credentials.provided?' was failing so made it
>> > 'credentials.nil?')
> The two test for different things: credentials.nil? tests if a
> credentials object (defined in lib/sinatra/lazy_auth.rb) was passed,
> whereas credentials.provided? tests if we received a user/password as
> part of the request.
>
> In a driver, credentials should never be nil - if anything fails becuse
> of that, we have a bug in server.rb or similar.
>
yes of course I realise they do different things: I just felt that it
was better than no checks at all given that there was already the
'.provided?' check. However, we know that our driver *always* passes
credentials and so in fact we don't even need the .nil? check. I had
been playing with this code since friday and couldn't get it to work
until I removed the .provided check... I still don't know exactly what
was going on...
marios
_______________________________________________
deltacloud-devel mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/deltacloud-devel
