thanks David, this has now been pushed. I removed the credentials.nil clause altogether.
On 18/05/10 19:35, David Lutterkort wrote: > On Tue, 2010-05-18 at 11:12 +0100, [email protected] wrote: >> From: marios<[email protected]> > > Patch looks good except: > >> diff --git a/server/lib/deltacloud/drivers/rimuhosting/rimuhosting_client.rb >> b/server/lib/deltacloud/drivers/rimuhosting/rimuhosting_client.rb >> index a07c881..9235e97 100755 >> --- a/server/lib/deltacloud/drivers/rimuhosting/rimuhosting_client.rb >> +++ b/server/lib/deltacloud/drivers/rimuhosting/rimuhosting_client.rb >> @@ -31,7 +31,9 @@ class RimuHostingClient >> @uri = URI.parse(baseuri) >> @service = Net::HTTP.new(@uri.host, @uri.port) >> @service.use_ssl = true >> - if credentials.provided? >> + if credentials.nil? >> + raise Deltacloud::AuthException.new >> + else >> @auth = "rimuhosting apikey=#{credentials.password}" >> end > > credentials should never be nil - if it is, there's some other bug > somewhere that drops it on the floor. Do you have a reproducer and a > stacktrace for when that happens ? > > David > > > _______________________________________________ > deltacloud-devel mailing list > [email protected] > https://fedorahosted.org/mailman/listinfo/deltacloud-devel _______________________________________________ deltacloud-devel mailing list [email protected] https://fedorahosted.org/mailman/listinfo/deltacloud-devel
