Overall, looks like a good start, couple comments inline. Ph, and the summary is waaaay too long, please update the commit message to something like: ImageDescriptor models and Xml Parsing
added models and migrations for image_descriptor and image_descriptor_target added util/repository_manager.rb which used for downloading/parsing repository xml files added util/image_descriptor_xml.rb used for creating/parsing image xml file Also, patch 2/4 should probably be rebased to be first in the series On Tue, 2010-06-01 at 19:36 +0200, [email protected] wrote: > From: Jan Provaznik <[email protected]> > > --- > src/app/models/image_descriptor.rb | 31 +++++ > src/app/models/image_descriptor_target.rb | 7 + > src/app/util/image_descriptor_xml.rb | 136 > ++++++++++++++++++++ > src/app/util/repository_manager.rb | 98 ++++++++++++++ > .../20100527095400_create_image_descriptors.rb | 14 ++ > ...100527095428_create_image_descriptor_targets.rb | 14 ++ > src/test/fixtures/image_descriptor_targets.yml | 7 + > src/test/fixtures/image_descriptors.yml | 7 + > .../unit/helpers/image_descriptor_helper_test.rb | 4 + > src/test/unit/image_descriptor_target_test.rb | 8 + > src/test/unit/image_descriptor_test.rb | 8 + > 11 files changed, 334 insertions(+), 0 deletions(-) > create mode 100644 src/app/models/image_descriptor.rb > create mode 100644 src/app/models/image_descriptor_target.rb > create mode 100644 src/app/util/image_descriptor_xml.rb > create mode 100644 src/app/util/repository_manager.rb > create mode 100644 src/db/migrate/20100527095400_create_image_descriptors.rb > create mode 100644 > src/db/migrate/20100527095428_create_image_descriptor_targets.rb > create mode 100644 src/test/fixtures/image_descriptor_targets.yml > create mode 100644 src/test/fixtures/image_descriptors.yml > create mode 100644 src/test/unit/helpers/image_descriptor_helper_test.rb > create mode 100644 src/test/unit/image_descriptor_target_test.rb > create mode 100644 src/test/unit/image_descriptor_test.rb > diff --git a/src/db/migrate/20100527095400_create_image_descriptors.rb > b/src/db/migrate/20100527095400_create_image_descriptors.rb > new file mode 100644 > index 0000000..9f91629 > --- /dev/null > +++ b/src/db/migrate/20100527095400_create_image_descriptors.rb > @@ -0,0 +1,14 @@ > +class CreateImageDescriptors < ActiveRecord::Migration > + def self.up > + create_table :image_descriptors do |t| > + t.binary :xml, :null => false > + t.string :uri > + t.boolean :complete > + t.timestamps > + end > + end > + > + def self.down > + drop_table :image_descriptors > + end > +end > diff --git a/src/db/migrate/20100527095428_create_image_descriptor_targets.rb > b/src/db/migrate/20100527095428_create_image_descriptor_targets.rb > new file mode 100644 > index 0000000..3cbe78f > --- /dev/null > +++ b/src/db/migrate/20100527095428_create_image_descriptor_targets.rb > @@ -0,0 +1,14 @@ > +class CreateImageDescriptorTargets < ActiveRecord::Migration > + def self.up > + create_table :image_descriptor_targets do |t| > + t.string :name, :null => false > + t.integer :build_id > + t.integer :image_descriptor_id > + t.timestamps > + end > + end This class ^ needs a 'status' field, which is just text that we will display to show where image is in the build process once submitted to builder > + > + def self.down > + drop_table :image_descriptor_targets > + end > +end Everything from this point down can go away. We are not using fixtures (much) adn we use rspec, not test_unit (not to mention I dont want any 'assert true' bogus tests added. This is another chunk that will need to be fixed, though not worth it at this point as much of this code will be replaced once with integrate with the external content service. > diff --git a/src/test/fixtures/image_descriptor_targets.yml > b/src/test/fixtures/image_descriptor_targets.yml > new file mode 100644 > index 0000000..5bf0293 > --- /dev/null > +++ b/src/test/fixtures/image_descriptor_targets.yml > @@ -0,0 +1,7 @@ > +# Read about fixtures at http://ar.rubyonrails.org/classes/Fixtures.html > + > +# one: > +# column: value > +# > +# two: > +# column: value > diff --git a/src/test/fixtures/image_descriptors.yml > b/src/test/fixtures/image_descriptors.yml > new file mode 100644 > index 0000000..5bf0293 > --- /dev/null > +++ b/src/test/fixtures/image_descriptors.yml > @@ -0,0 +1,7 @@ > +# Read about fixtures at http://ar.rubyonrails.org/classes/Fixtures.html > + > +# one: > +# column: value > +# > +# two: > +# column: value > diff --git a/src/test/unit/helpers/image_descriptor_helper_test.rb > b/src/test/unit/helpers/image_descriptor_helper_test.rb > new file mode 100644 > index 0000000..0c9addf > --- /dev/null > +++ b/src/test/unit/helpers/image_descriptor_helper_test.rb > @@ -0,0 +1,4 @@ > +require 'test_helper' > + > +class ImageDescriptorHelperTest < ActionView::TestCase > +end > diff --git a/src/test/unit/image_descriptor_target_test.rb > b/src/test/unit/image_descriptor_target_test.rb > new file mode 100644 > index 0000000..826391b > --- /dev/null > +++ b/src/test/unit/image_descriptor_target_test.rb > @@ -0,0 +1,8 @@ > +require 'test_helper' > + > +class ImageDescriptorTargetTest < ActiveSupport::TestCase > + # Replace this with your real tests. > + test "the truth" do > + assert true > + end > +end > diff --git a/src/test/unit/image_descriptor_test.rb > b/src/test/unit/image_descriptor_test.rb > new file mode 100644 > index 0000000..1b8e292 > --- /dev/null > +++ b/src/test/unit/image_descriptor_test.rb > @@ -0,0 +1,8 @@ > +require 'test_helper' > + > +class ImageDescriptorTest < ActiveSupport::TestCase > + # Replace this with your real tests. > + test "the truth" do > + assert true > + end > +end _______________________________________________ deltacloud-devel mailing list [email protected] https://fedorahosted.org/mailman/listinfo/deltacloud-devel
