On 07/06/10 17:03 -0400, Mohammed Morsi wrote:
>diff --git a/src/app/controllers/dashboard_controller.rb
>b/src/app/controllers/dashboard_controller.rb
>index 6f02c4e..0a3e948 100644
>--- a/src/app/controllers/dashboard_controller.rb
>+++ b/src/app/controllers/dashboard_controller.rb
>@@ -61,7 +61,8 @@ class DashboardController < ApplicationController
> @is_admin = @current_user.permissions.collect { |p| p.role }.
> find { |r| r.name == "Administrator" }
>
>- @hide_getting_started =
>cookies["#...@current_user.login}_hide_getting_started"]
>+ @hide_getting_started = true
>+ #...@hide_getting_started =
>cookies["#...@current_user.login}_hide_getting_started"]
Looks like a hack ;-) But I hope it's ok ;)
(maybe some comment, why it's forced to be true would be appreciated)
>+ = account.provider.name + ": " + account.name
If .name == nil, this code will raise Exception ;-)
> .header_info
> #hi-username
>- = link_to @current_user.login, { :controller => "users", :action =>
>"show"} unless @current_user.nil?
>+ = link_to @current_user.first_name + " " + @current_user.last_name, {
>:controller => "users", :action => "show"} unless @current_user.nil?
Just a small hint: Avoid using @var + " " + @var2, because it may lead to Nil
exception if first_name or last_name will be nil. If this can't happen, it
should be OK.
I prefer this instead: "#...@current_user.first_name}
#...@current_user.last_name}"
Anyway, this code looks sane for me. Applied cleanely. ACKing this patch.
-- Michal
--
--------------------------------------------------------
Michal Fojtik, [email protected], +420 532 294 4307
Ruby / Ruby On Rails Developer
Deltacloud API: http://deltacloud.org
--------------------------------------------------------
_______________________________________________
deltacloud-devel mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/deltacloud-devel
