Hi David, >> @@ -22,7 +22,7 @@ require 'AWS' >> class Instance >> attr_accessor :keyname >> attr_accessor :authn_error >> - >> + attr_accessor :launch_time >> def authn_feature_failed? >> return true unless authn_error.nil? >> end > > I hadn't noticed that this extension of the Instance class had slipped > in. I am very much against doing this, since it will lead to > driver-specific models with ugly ripple effects all the way to the > views. > > The Instance class should be declared in one place, with all its > attributes.
I had originally declared the launch_time attribute in the Instance class - when I saw that only two of the backend clouds provide this info I decided to make it driver specific. I take your point though and will move it back to the Instance model and send out a fresh patch, marios _______________________________________________ deltacloud-devel mailing list [email protected] https://fedorahosted.org/mailman/listinfo/deltacloud-devel
