On Wed, 2010-06-30 at 08:54 -0400, Scott Seago wrote:
> Ian Main wrote:
> > On Tue, 2010-06-29 at 15:23 -0400, Jason Guiditta wrote:
> >
> >> Minor errors first:
> >>
> >>
> >> warning: 4 lines add whitespace errors.
> >> src/app/models/hardware_profile_observer.rb:1: new blank line at EOF.
> >> src/app/models/image_observer.rb:1: new blank line at EOF.
> >> src/app/util/condormatic.rb:1: new blank line at EOF.
> >> src/config/initializers/condor_classads_sync.rb:1: new blank line at
> >> EOF.
> >>
> >
> > Believe it or not through many years of my being a software developer
> > this was a requirement :)
> >
> > eg:
> >
> > http://www.microchip.com/forums/m439495-print.aspx
> >
> > So I stubbornly continue to do this.
> >
> >
> By all means keep ending your files w/ newline -- 'no newline' confuses
> diff, and I'm not sure emacs will even let you save a file without it
> adding a newline at the end for you.
>
> However I think the whitespace error noted above by git was blank empty
> lines at the end of the file -- i.e. 2 or more newlines at the end of
> the file. That's different and, I believe, not there in many of our
> files right now.
>
> Scott
Yeah it's all good I'll remove them for the next patch. :) It's just a
habbit I picked up along the way.
Ian
_______________________________________________
deltacloud-devel mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/deltacloud-devel
