On 07/20/2010 10:13 PM, Jason Guiditta wrote: > On Thu, 2010-07-15 at 16:18 +0200, Jan Provaznik wrote: >> On 07/13/2010 10:28 PM, Jason Guiditta wrote: >>> On Tue, 2010-07-13 at 14:32 +0200, [email protected] wrote: >>>> From: Jan Provaznik<[email protected]> >>>> >>>> Replaced Datatables plugin with simpler HTML table because some >>>> issues when JS is off. Major issue with Datatables is that it doesn't >>>> degrades gracefully when JS is off and server-side pagination. >>>> >>>> Images and instances are now displayed by HTML table >>>> (there is new helper 'paginated_table'), this table keeps >>>> all common functions like sorting, paginating, searching and >>>> code is cleaner. Works with JS on or off. > > > ACK. Much improved, thanks for the second rev here. However, there are > a couple small issues that should be addressed (separately, not in this > patch): > > * When javascript is off, if you click a pool in left nav, you get an > unstyled list instead of tabs. Instead, this should still appear to be > tabs, and clicking them should just cause a page reload. With a minor > caveat, I suspect this should be as simple as setting a pre-defined > style from jq-ui on the list (at least it used to work this way). If > not, we'll need to mix that style into our compass stuff so the tabs > always look right. Tomas, this might be a good one for you to look at > if you have some time. > * When javascript is off, clicking the link in the list above still > returns the partial only. It should instead return the full layout with > tab selected. (I may have a quick at least partial fix for this if I > have time before I knock off today)
This issue is relevant to previous "unstyled list instead of tabs" issue and will be fixed with it (there is ajax=true param for tab links even if JS is off). > * Sort of columns in table should probably hook into the mask as well, > so it is clear that something is happening, given the long pause before > anything is returned to update the table. > Patch is on the way. > There was another issue I hit, but completely unrelated to this patch, > so I will send a mail describing that to the list in a bit. > > -j > _______________________________________________ deltacloud-devel mailing list [email protected] https://fedorahosted.org/mailman/listinfo/deltacloud-devel
