On Mon, 2010-08-02 at 14:47 +0200, [email protected] wrote: > From: Jan Provaznik <[email protected]> > > * html_error_page chose layout by @layout, but @layout is nil when error > occurs (for example in controller) and then popup-error.rhtml template > is used (this template should be used for ajax-requests, shouldn't be?) > -> request.xhr? is used instead of @layout > * when @layout was set, html_error_page set only layout and not template, so > error wasn't displayed > -> added simple layout/error.rhtml > * passing of title and errmsg is now done with :locals, passing > with @title and @errmsg doesn't work, if TemplateError occurs (for example > use of undefined variable in template)
This appears to be fine, looks reasonable, pages stil seem to render fine, but kind of hard to tell for sure without being able to easily test for the error before the patch, and lack of error after. I'll say ACK for now, but if you could get a test case in for this I would be much happier with the fix. -j _______________________________________________ deltacloud-devel mailing list [email protected] https://fedorahosted.org/mailman/listinfo/deltacloud-devel
