On Tue, 2010-08-17 at 16:57 +0200, Jan Provaznik wrote: > On 08/16/2010 11:25 PM, Jason Guiditta wrote: > > On Tue, 2010-08-03 at 15:44 +0200, [email protected] wrote: > >> From: Jan Provaznik<[email protected]> > >> > >> As we dropped side nav panel, it's not necessary to load providers > >> and pools for each request but only when it's needed. > >> > >> get_nav_items before_filter is not removed completely because of > >> side_panel is still used in instances and pools controllers. I also > >> moved get_nav_items between protected methods and added require_user > >> before_filter into settings and quota controllers (side effect of > >> get_nav_items is setting @current_user) > >> --- > > > > Mostly ACK, minor fix suggestion inline. Also, maybe it would make > > sense to move the require_user filter up to application_controller, and > > just have a few exceptions, as there are not many pages you can get to > > in the app w/o being logged in? If so, that would be a simple scenario > > added to the authorization feature checking if the user is redirected to > > login page and receives appropriate error message if he attempts to > > access a secure page. > > > > Do you mind, if moving require_user to application_controller will be > separate patch? Separate patch for that is fine sure, just occurred to me as I was looking through this yesterday.
-j _______________________________________________ deltacloud-devel mailing list [email protected] https://fedorahosted.org/mailman/listinfo/deltacloud-devel
