On 09/08/2010 07:59 PM, Jason Guiditta wrote:
> On Wed, 2010-09-08 at 18:09 +0200, [email protected] wrote:
>> From: Jozef Zigmund<[email protected]>
>>
>> ---
>>   src/app/views/user_sessions/new.haml     |   18 ++++++++++++++++++
>>   src/app/views/user_sessions/new.html.erb |   27 ---------------------------
>>   2 files changed, 18 insertions(+), 27 deletions(-)
>>   create mode 100644 src/app/views/user_sessions/new.haml
>>   delete mode 100644 src/app/views/user_sessions/new.html.erb
>>
> ACK with minor caveat that name of this commit should be fixed to not
> say 'rev 2' at the end.  Not sure your git experience, so apologies if
> this seems pedantic, but this is how you would fix the patch:
> $ git rebase -i HEAD~<number of commits back you need to fix>
>
> this will bring you to a view where you can change the entry for this
> commit from 'pick' to 'edit'.  You will then get output with directions
> telling you that you can amend your commit.  Do this with:
> $ git commit --amend

A small suggestion: if all you need is to change the commit message, you 
can choose "reword" instead of "edit". This will let you edit the commit 
message directly without having to run the `git commit --amend` and `git 
rebase --continue` commands.

And to shave off a few additional miliseconds, use "r" instead of 
"reword" :-)

>
> then just change the subject as appropriate, and then:
> $ git rebase --continue
>
> I will have similar suggestion on the other follow-up patch, and both
> can be done in the same rebase if you like.
>
> _______________________________________________
> deltacloud-devel mailing list
> [email protected]
> https://fedorahosted.org/mailman/listinfo/deltacloud-devel
_______________________________________________
deltacloud-devel mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/deltacloud-devel

Reply via email to