On Thu, 2010-09-16 at 16:32 -0400, Mohammed Morsi wrote:
> Looks good. ACK with one quick question below.
>
> On 09/15/2010 07:01 PM, Ian Main wrote:
> > This patch removes the call to go to condor to sync states since this
> > should now be done by dbomatic.
> >
> > Signed-off-by: Ian Main<[email protected]>
> > ---
> > src/app/controllers/instance_controller.rb | 3 ---
> > src/app/controllers/pool_controller.rb | 2 --
> > 2 files changed, 0 insertions(+), 5 deletions(-)
> >
> > diff --git a/src/app/controllers/instance_controller.rb
> > b/src/app/controllers/instance_controller.rb
> > index dcf0fa2..4d34b9f 100644
> > --- a/src/app/controllers/instance_controller.rb
> > +++ b/src/app/controllers/instance_controller.rb
> > @@ -32,9 +32,6 @@ class InstanceController< ApplicationController
> > def index
> > require_privilege(Privilege::INSTANCE_VIEW)
> >
> > - # go to condor and sync the database to the real instance states
> > - condormatic_instances_sync_states
> > -
> > @pools = Pool.list_for_user(@current_user, Privilege::INSTANCE_MODIFY)
> > @order_dir = params[:order_dir] == 'desc' ? 'desc' : 'asc'
> > @order = params[:order] || 'name'
> > diff --git a/src/app/controllers/pool_controller.rb
> > b/src/app/controllers/pool_controller.rb
> > index c0a38c9..187da09 100644
> > --- a/src/app/controllers/pool_controller.rb
> > +++ b/src/app/controllers/pool_controller.rb
> > @@ -41,8 +41,6 @@ class PoolController< ApplicationController
> > #FIXME: clean this up, many error cases here
> > @pool = Pool.find(params[:id])
> > require_privilege(Privilege::INSTANCE_VIEW,@pool)
> > - # Go to condor and sync the database to the real instance states
> > - condormatic_instances_sync_states
> > @pool.reload
>
> Does the @pool.reload which is being left here have anything to do with
> the condormatic_instance_sync_states? If so it should be removed as
> well. If not, just ignore this comment and feel free to push.
I think it's to do with the permissions check. It was there before I
added the condor sync call so it stays..
I pushed this now.
Ian
_______________________________________________
deltacloud-devel mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/deltacloud-devel
