On Tue, 2010-09-21 at 16:06 +0200, [email protected] wrote:
> From: Jozef Zigmund <[email protected]>
> 
> ---
>  src/app/controllers/users_controller.rb |    6 +++++-
>  src/app/views/users/_form.haml          |   14 +++++++-------
>  src/app/views/users/new.haml            |   13 ++++++-------
>  3 files changed, 18 insertions(+), 15 deletions(-)
> 
My previous reply applies here too.  Aside from the rebase, my general
comment on this is that it looks ok, but I would like to see you move
these new strings (like "Choose a username") out into the en.yml file,
so they are i18n, less to clean up later.

-j

_______________________________________________
deltacloud-devel mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/deltacloud-devel

Reply via email to