On Mon, 2010-09-27 at 18:50 -0400, Chris Lalancette wrote:
> With all of this in place, dbomatic now behaves like a
> proper daemon, including daemonizing by default and
> having the initscript respond to start/stop/status.
> 
> Signed-off-by: Chris Lalancette <[email protected]>
> ---
>  conf/deltacloud-dbomatic |    7 ++++---
>  src/dbomatic/dbomatic    |   42 ++++++++++++++++++++++++++++++++++--------
>  2 files changed, 38 insertions(+), 11 deletions(-)

<snip>

> diff --git a/src/dbomatic/dbomatic b/src/dbomatic/dbomatic
> index 9d15a54..f6647ba 100755
> --- a/src/dbomatic/dbomatic
> +++ b/src/dbomatic/dbomatic
> @@ -18,41 +18,49 @@
>  # also available at http://www.gnu.org/copyleft/gpl.html.
>  
>  $: << File.join(File.dirname(__FILE__), "../dutils")
> +
> +require 'rubygems'
>  require 'dutils'
>  require 'nokogiri'
>  require 'rb-inotify'
>  require 'optparse'
>  
Just a minor note.  I know you already pushed this, and this wont break
anything, but you shouldn't really need rubygems require here, as it is
already in active_record_env.rb (or it could be removed from there and
only be here, which might actually be better - since that is really only
used by daemon scripts anyway).

-j

_______________________________________________
deltacloud-devel mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/deltacloud-devel

Reply via email to