On 10/21/2010 09:47 AM, Jakub Steiner wrote: > ----- "Mohammed Morsi"<[email protected]> wrote: > >> The real problem isn't that the form is in a modal box, its that the >> input field size was set too small. Granted I'll admit I should've >> considered other elements on the site affected by this change and >> simply >> added a new style rule which just applies to the large buttons on the > Hi there. > Sorry I wasn't quite clear on that modalbox part. The state of the form > before your patch was not the ultimate intended behaviour so your patch > didn't really introduce the broken behavior wrt to wrapping in .modalbox. The > fact that the fields don't fit in the modal dialog which your patch tried to > address by shrinking the width of the input fields is not something that > needs addressing though (and it fails for the login dialog thus me not liking > it). What I think should have been done is not to use the modalbox when you > have the navigation tabs visible already and have the forms inline like all > the others. Which is what I tried to suggest in bug > https://bugzilla.redhat.com/show_bug.cgi?id=642535 > >> Lets try to work together to come up with a solution that works for >> everyone, perhaps through the combination of both our patches. > Nod. I'm pretty sure there is a more elegant way to combine the > new/edit/logged in/logged out case, but my rails skills are limited so take > the attached patch with a grain of salt. > No worries. Your patch looks good, I added the bits fixing the form to include error messages, and one fix to include the quota field for when admins are creating new users and sent it to the list. Think it should now address all of the issues in a reliable way.
-Mo _______________________________________________ deltacloud-devel mailing list [email protected] https://fedorahosted.org/mailman/listinfo/deltacloud-devel
