A few notes below:

On Nov 16, 2010, at 1:59 PM, Tomas Sedovic wrote:

> ACK
> 
> 
> ----- Original Message -----
> From: [email protected]
> To: [email protected]
> Sent: Monday, November 15, 2010 4:16:15 PM GMT +01:00 Amsterdam / Berlin / 
> Bern / Rome / Stockholm / Vienna
> Subject: [deltacloud-devel] [PATCH aeolus] BZ#643096 Added test for cancel 
> button on new user page
> 
> From: Martyn Taylor <[email protected]>
> 
> ---
> src/features/step_definitions/user_steps.rb |   10 +++++++++-
> src/features/user.feature                   |    9 +++++++++
> 2 files changed, 18 insertions(+), 1 deletions(-)
> 
> diff --git a/src/features/step_definitions/user_steps.rb 
> b/src/features/step_definitions/user_steps.rb
> index 09bbaf8..19d63c2 100644
> --- a/src/features/step_definitions/user_steps.rb
> +++ b/src/features/step_definitions/user_steps.rb
> @@ -1,3 +1,11 @@
> Given /^there is a user "([^"]*)"$/ do |name|
> -  @user = User.find_by_login(name)
> + User.find_by_login(name).should_not == nil
> +end
> +
> +Given /^there are (\d+) users$/ do |number|
> +  User.all.size.should == number.to_i
> +end

You can use instead of User.all.size SQL based method count: User.count
It's faster, better, more sexy. ;)

> +
> +Then /^there should only be (\d+) users$/ do |number|
> +  User.all.size.should == number.to_i
> end
> diff --git a/src/features/user.feature b/src/features/user.feature
> index e11dfba..2c3921c 100644
> --- a/src/features/user.feature
> +++ b/src/features/user.feature
> @@ -25,3 +25,12 @@ Feature: Manage Users
>     And I fill in "user[password_confirmation]" with "new password"
>     And I press "Save"
>     Then I should see "User updated!"
> +
> +  Scenario: Administrator cancels the creation of a user account
> +    Given I am on the users page
> +    And there are 2 users
> +    When I follow "create"
> +    Then I should be on the new user page
> +    When I follow "cancel"
> +    Then there should only be 2 users
> +    And I should be on the users page
> -- 
> 1.7.2.3
> 
> _______________________________________________
> deltacloud-devel mailing list
> [email protected]
> https://fedorahosted.org/mailman/listinfo/deltacloud-devel
> _______________________________________________
> deltacloud-devel mailing list
> [email protected]
> https://fedorahosted.org/mailman/listinfo/deltacloud-devel

_______________________________________________
deltacloud-devel mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/deltacloud-devel

Reply via email to