On 12/21/2010 03:07 PM, Martyn Taylor wrote: > Hi Jan, > > Looking at the new method here, and it seems there will be a slight issue > with displaying the correct message for starting an instance. > > `condormatic_instance_create(@task)` will checks quota and saves the instance > should there be sufficient quota left. This then initiates the > instance_observer, which increments the number of instances, for each > associated quota. > > In the new method, `check_can_start_instance(@task)` is called after this > method. Which essentially checks to see if another instance can be started. > Meaning that when a quota is at it's maximum limit after > condormatic_instance_create(@task) has updated. The instance will be started > but flash[:warning] = "Quota Exceeded: Instance will not start until you have > free quota" will be shown. > > Ideally condormatic_instance_create(@task) should throw an exception, when it > can not start instance due to insufficient quota, this way we could inspect > it to find out what the issue was. For now I suggest we do the Quota check > before calling condormatic_instance_create(@task). > > Thanks > > Martyn >
Hi, you are right, going to resend this one patch with fix. Good catch. Jan _______________________________________________ deltacloud-devel mailing list [email protected] https://fedorahosted.org/mailman/listinfo/deltacloud-devel
