On 01/07/11 - 10:56:14AM, Mohammed Morsi wrote: > On 01/07/2011 09:07 AM, Chris Lalancette wrote: > >On 01/07/11 - 01:22:38AM, Mohammed Morsi wrote: > >>--- > >> bin/dc-install | 1 + > >> bin/dc-uninstall | 1 + > >> contrib/deltacloud_recipe.spec | 1 + > >> recipes/apache/manifests/init.pp | 34 > >> +++++++++++++++++ > >> .../files/aggregator-httpd-ssl.conf | 38 > >> ++++++++++++++++++++ > >> .../deltacloud_recipe/files/aggregator-httpd.conf | 23 ++++++++++++ > >> recipes/deltacloud_recipe/manifests/aggregator.pp | 16 +++++++-- > >> recipes/deltacloud_recipe/manifests/deltacloud.pp | 7 ++++ > >> 10 files changed, 120 insertions(+), 3 deletions(-) > >> create mode 100644 recipes/apache/manifests/init.pp > >> create mode 100644 > >> recipes/deltacloud_recipe/files/aggregator-httpd-ssl.conf > >> create mode 100644 recipes/deltacloud_recipe/files/aggregator-httpd.conf > >So I didn't actually review this patch, but I just want to say that I think > >we should hold off adding new features to the recipe until we get the > >existing > >recipe working and replacing deltacloud-configure. That way we can make sure > >that current things still work without worrying about the new features. I > >know jzigmund also has some new features he wants to add to the configure > >script as well. > > > > I agree w/ this on principal, though in reality I get the impression > that the security tasks over deltacloud need to be in asap and are > due on a tight schedule. I don't think there is much harm in > developing these features and letting them sit on list until the > recipe is ready to accept them (they can easily be rebased as > needed). Of course I don't object to multiple people hacking to > improve different aspects of the recipe at the same time.
Yeah, that's totally fine. I just didn't want to commit them at the same time we are trying to get the thing stable :). -- Chris Lalancette _______________________________________________ deltacloud-devel mailing list [email protected] https://fedorahosted.org/mailman/listinfo/deltacloud-devel
