[ 
https://issues.apache.org/jira/browse/DELTASPIKE-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232560#comment-13232560
 ] 

Mark Struberg commented on DELTASPIKE-124:
------------------------------------------

that's perfectly fine. CdiContainer#shutdown() of any CdiContainer should stop 
all still open contexts anyway!
This is true for built-in Contexts and should also be the case for custom 
contexts. They can (and should) observe the BeforeShutdown event to gracefully 
cleanup any contextual instances left in their context stores. 
                
> tests in ContainerCtrlTckTest don't stop contexts at the end
> ------------------------------------------------------------
>
>                 Key: DELTASPIKE-124
>                 URL: https://issues.apache.org/jira/browse/DELTASPIKE-124
>             Project: DeltaSpike
>          Issue Type: Bug
>          Components: Tests
>            Reporter: Gerhard Petracek
>            Assignee: Mark Struberg
>            Priority: Minor
>             Fix For: 0.2-incubating
>
>         Attachments: DELTASPIKE-124.patch
>
>
> no test in ContainerCtrlTckTest calls:
>         CdiContainer#getContextControl#stopContexts
> before
>         CdiContainer#shutdown
> imo the current approach is too error prone - see DELTASPIKE-123

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to