On 25 Mar 2012, at 17:30, Gerhard Petracek wrote:

> hi pete,
> 
> that would be possible e.g. with AnnotationBuilder. however, it isn't
> possible with all of them.

Why?

> -> we already moved internal helpers to
> org.apache.deltaspike.core.util
>> if< we need them in the api-module.
> they might not provide a stable api (over time) or are quite special.
> we moved them there to remove the visibility via an organizational approach.

I have no problem with this approach.

Perhaps you could expand on what you mean here then? Do you mean extract 
interfaces from these classes and move the implementation to core?



I can't see how you can reduce the visibility without changing the API?

> 
> regards,
> gerhard
> 
> 
> 
> 2012/3/25 Pete Muir <pm...@redhat.com>
> 
>> I assume you mean the visibility of the constructors of AnnotationBuilder,
>> ImmutableInjectioPoint, InjectableMethod, and ParameterValue?
>> 
>> 
>> Begin forwarded message:
>> 
>>> From: "Gerhard Petracek (Created) (JIRA)" <j...@apache.org>
>>> Subject: [jira] [Created] (DELTASPIKE-129) re-visit visibility of
>> AnnotationBuilder, ImmutableInjectionPoint, InjectableMethod and
>> ParameterValueRedefiner
>>> Date: 25 March 2012 16:39:27 GMT+01:00
>>> To: deltaspike-dev@incubator.apache.org
>>> 
>>> re-visit visibility of AnnotationBuilder, ImmutableInjectionPoint,
>> InjectableMethod and ParameterValueRedefiner
>>> 
>> ---------------------------------------------------------------------------------------------------------------
>>> 
>>>                Key: DELTASPIKE-129
>>>                URL:
>> https://issues.apache.org/jira/browse/DELTASPIKE-129
>>>            Project: DeltaSpike
>>>         Issue Type: Task
>>>         Components: Core
>>>   Affects Versions: 0.1-incubating
>>>           Reporter: Gerhard Petracek
>>>           Assignee: Jason Porter
>>>            Fix For: 0.2-incubating
>>> 
>>> 
>>> ... since those classes aren't intended to be used by users, we should
>> re-visit them.
>>> if we can't keep them package-private, we could move them to the
>> util-package (like we did with ClassDeactivation now ClassDeactivationUtils)
>>> 
>>> --
>>> This message is automatically generated by JIRA.
>>> If you think it was sent incorrectly, please contact your JIRA
>> administrators:
>> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
>>> For more information on JIRA, see:
>> http://www.atlassian.com/software/jira
>>> 
>>> 
>> 
>> 

Reply via email to