I thought about posting comments on the commit, but this is probably more visible to the whole group. If we're going to call it a credential and go with the more common security names, shouldn't it be called a Principal then the authentication information would be the Credential? If we don't want to go down that way I understand.
On Mon, Apr 16, 2012 at 15:26, Bruno Oliveira <[email protected]> wrote: > Hi folks. > > I was just trying to figure out a flexible way to use DS authentication > module and did some refactoring into User and Credential stuff. Just some > suggestions: > > 1- User class renaming to CredentialAuthInfo, because User has a little > bit of ambiguity, > 2- We can't guarantee that User will always have id, for this reason only > username/password should be enough, allowing users to decorate your classes > with another authentication methods like OAuth > 3- LoginCredential should receive an object instead > of straight username/password > > These are just suggestions and I would like to pick some jira or create > the new one about it. > > > https://github.com/abstractj/incubator-deltaspike/commit/0757366a7b129a053f34a3e0db426b48c73767be > > What do you think? > > -- > > -- > "Know the rules well, so you can break them effectively" - Dalai Lama XIV > - > @abstractj > - > Volenti Nihil Difficile > -- Jason Porter http://lightguard-jp.blogspot.com http://twitter.com/lightguardjp Software Engineer Open Source Advocate Author of Seam Catch - Next Generation Java Exception Handling PGP key id: 926CCFF5 PGP key available at: keyserver.net, pgp.mit.edu
