Yes, you are right, it should go into the same package as the BeanBuilder and that stuffŠ so for our current separation of the modules it has to go into api.
Am 28.09.12 17:21 schrieb "Jason Porter" unter <[email protected]>: >API sounds fine > >On Fri, Sep 28, 2012 at 3:02 AM, Romain Manni-Bucau ><[email protected]>wrote: > >> sounds fine... >> >> btw is we see DS as an utility lib remove util from package name :p >> >> *Romain Manni-Bucau* >> *Twitter: @rmannibucau* >> *Blog: **http://rmannibucau.wordpress.com/*< >> http://rmannibucau.wordpress.com/> >> *LinkedIn: **http://fr.linkedin.com/in/rmannibucau* >> >> >> >> >> 2012/9/28 Mark Struberg <[email protected]> >> >> > Arne, Romain >> > >> > Until now I think we did put all SPI stuff into api. There was a long >> > discussion very early on the list that we do not like an own spi >>module. >> > >> > The reason was that DeltaSpike is a tool project anyway, so there is a >> > very flexible line between 'using' and 'extending'. >> > >> > Looking a bit further we already have stuff like the >>BaseImmutableBean in >> > util.bean. Thus I think util.context is fine as well. It doesnt need >>any >> > external dependencies neither, so might really be fine in core-api. >> > >> > LieGrue, >> > strub >> > >> > >> > >> > ----- Original Message ----- >> > > From: Romain Manni-Bucau <[email protected]> >> > > To: [email protected]; Mark Struberg < >> > [email protected]> >> > > Cc: >> > > Sent: Friday, September 28, 2012 10:50 AM >> > > Subject: Re: where to put all the Context util helpers? >> > > >> > > Hi, >> > > >> > > maybe we should create something between api and impl. Kind of >> core-util. >> > > Wdyt? >> > > >> > > if not core-api is fine. >> > > >> > > *Romain Manni-Bucau* >> > > *Twitter: @rmannibucau* >> > > *Blog: >> > > >>**http://rmannibucau.wordpress.com/*<http://rmannibucau.wordpress.com/ >> > >> > > *LinkedIn: **http://fr.linkedin.com/in/rmannibucau* >> > > >> > > >> > > >> > > >> > > 2012/9/28 Mark Struberg <[email protected]> >> > > >> > >> Hi folks! >> > >> >> > >> see DELTASPIKE-274 [1] >> > >> >> > >> Where should I put those helpers? >> > >> >> > >> Is it a good fit for core-api? e.g. in a >> > >> org.apache.deltaspike.core.api.util.context package >> > >> Or should I place it in core-impl? >> > >> >> > >> What it will contain: >> > >> >> > >> * ContextualBeanBag: contains the CreationalContext<T>, the >> > > Contextual<T> >> > >> and the instance T which can be stored in a Map. >> > >> The ContextualBeanBag is Serializable and will automatically try >>to >> > get >> > >> the passivation >> > >> >> > >> * AbstractContext which contains the logic for >> > >> # destroy(Contextual) >> > >> # destroyAll() (needed at the end of a contexts lifecycle) >> > >> # all the creation logic >> > >> >> > >> wdyt? where to put it? >> > >> >> > >> LieGrue, >> > >> strub >> > >> >> > >> [1] https://issues.apache.org/jira/browse/DELTASPIKE-274 >> > >> >> > > >> > >> > > > >-- >Jason Porter >http://lightguard-jp.blogspot.com >http://twitter.com/lightguardjp > >Software Engineer >Open Source Advocate >Author of Seam Catch - Next Generation Java Exception Handling > >PGP key id: 926CCFF5 >PGP key available at: keyserver.net, pgp.mit.edu
