#3181: Replace Pywin32
---------------------+----------------------------
Reporter: Doadin | Owner:
Type: patch | Status: new
Priority: trivial | Milestone: needs verified
Component: Unknown | Version: develop (git)
Keywords: |
---------------------+----------------------------
After the issues with appveyor and pip and windows, I was looking over the
code that needs pywin32 and noticed at least form a quick glance, most if
not all code that uses pywin32 in deluge can be replaced by ctypes. more
specifically:
ctypes.windll.kernel32.CreateMutexA
and
ctypes.windll.kernel32.SetConsoleCtrlHandler
the mutex code does seem like it would be a bit more code a sample can be
seen here:
http://code.activestate.com/recipes/577794-win32-named-mutex-class-for-
system-wide-mutex/
However just those two can replace 90% of the need of pywin32. And im sure
the last 10% can be done as well I just havn't looked that much yet. Is
there a reason not to change? Im sure pywin32 does just about the same
thing and normally not trying to recreate something that is already done
would be a good idea however I think our use uses so little of the module
as a whole that in this case it would be worth it.
--
Ticket URL: <https://dev.deluge-torrent.org/ticket/3181>
Deluge <http://deluge-torrent.org/>
Deluge Project
--
You received this message because you are subscribed to the Google Groups
"Deluge Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/deluge-dev.
For more options, visit https://groups.google.com/d/optout.
