#3207: Core: migrate from Twisted to Asyncio
------------------------------+---------------------------
Reporter: andar | Owner: andar
Type: feature-request | Status: new
Priority: major | Milestone: 2.x
Component: Core | Version: develop (git)
Resolution: | Keywords:
------------------------------+---------------------------
Comment (by JohnDoee):
This strikes me as basically a needless rewrite of Deluge.
First thing first, you can use asyncio (and all it brings with it) in
Twisted by installing the asyncio reactor. See the examples here of how
Django Channels does it here:
https://github.com/django/daphne/blob/e93643ff5a2797f05e88bc59800d7b4dbf41765d/daphne/server.py#L1-L19
https://twistedmatrix.com/documents/current/api/twisted.internet.asyncioreactor.html
The example you use to show how the code would differ tries specifically
to be obtuse as they specify keyword equivalency and then doesn't use them
equally (i.e. they skip @inlineCallbacks as that'd make the code look VERY
similar while saying async def equals it).
Using inlineCallbacks has been part of Twisted for 12-14 years, which
would make it predate Deluge? The choice of not using it everywhere must
be a design choice?
Not sure how Twisted is "overkill" in any way. Debian stripped it down
into smaller packages as it's just a small core and a large bunch of
protocols.
To end this, I'm annoyed because it'll break my own plugin while only
bringing maybe 5MB of saved space.
Feel free to change reactor but PLEASE abandon the removal of Twisted.
--
Ticket URL: <https://dev.deluge-torrent.org/ticket/3207#comment:5>
Deluge <http://deluge-torrent.org/>
Deluge Project
--
You received this message because you are subscribed to the Google Groups
"Deluge Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/deluge-dev.
For more options, visit https://groups.google.com/d/optout.
