#3481: deluge-web's password field has broken-looking focus outline, in Firefox, due to UA-string-sniffing ----------------------------+-------------------- Reporter: dholbert | Type: bug Status: new | Priority: minor Milestone: needs verified | Component: Web UI Version: 1.3.15 | Keywords: ----------------------------+-------------------- Steps to reproduce:
(1) Visit a deluge-web instance, using Firefox as your web browser. (2) Click to focus the password field. ACTUAL RESULTS: There are awkward-looking colorful bars on the left side and the right side of the password field. EXPECTED RESULTS: No such bars. ANALYSIS: These bars are there as part of the browser's default focus outline, but they're only visible on the left and right sides because this particular element is inside of a clipped `overflow:auto` container. This issue *would* affect Safari as well, since Safari draws very-similar default focus outlines to Firefox, but Deluge has some CSS to prevent this in Safari (using the "ext-webkit" CSS class selector, where "ext-webkit" is a class that Deluge adds to the page's body element when it detects that the browser is WebKit i.e. Safari). Here's the rule in question (which can be found in https://git.deluge- torrent.org/deluge/plain/deluge/ui/web/css/ext-all-notheme.css ): {{{ .ext-webkit :focus { outline: none !important; } }}} SUGGESTED TRIVIAL FIX: Deluge should just broaden that CSS rule to apply in Firefox as well (using "ext-gecko" selector). So it should instead start with: {{{ .ext-webkit :focus, .ext-gecko :focus { }}} VERSION INFO: I'm using deluge-web package 1.3.15-2 in Raspbian (and Firefox 91 on Ubuntu 21.04). But I suspect this affects all newer deluge-web versions as well, given that the CSS rule is unchanged at https://git.deluge- torrent.org/deluge/plain/deluge/ui/web/css/ext-all-notheme.css (assuming that file is newer than 1.3.15). -- Ticket URL: <https://dev.deluge-torrent.org/ticket/3481> Deluge <https://deluge-torrent.org/> Deluge Project -- You received this message because you are subscribed to the Google Groups "Deluge Dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/deluge-dev/047.81717bcfb908179d7d2e72b893c55a26%40deluge-torrent.org.
