I agree about GTK2 (not to mention that there's probably no one to test it anymore, which means additional maintenance overhead for no reason), also the atril switch. I'm no autotools wizard either, but I can try later tomorrow.

On 10/4/25 11:27, Richard Shann wrote:
On Thu, 2025-10-02 at 20:31 +0200, sj wrote:
I think --enable-atril isn't even a configure option, USE_ATRIL is
only defined if --enable-evince is true but the evince development
packages are missing so it falls back to Atril. Actually, USE_ATRIL
is defined in an if test "x$have_evince" != xno block (this is just
the configure option), if a use_atril variable is also on, which is
only set if the evince checks failed but it finds atril,

I think Denemo should default to atril and only use evince if it is not
available, as evince has failed to honor the point and click in PDF for
years now, which limits its usefulness in Denemo. Unfortunately I've
never managed to get my head around autotools so I'm unsure how to
arrange this.

  at least in the GTK3 branch. I think this is the same for GTK2 but I
haven't looked at it too much.

I think GTK2 is now old enough to be forgotten...

Richard



Ekkor: 2025. október 2. 19:13:49 CEST, Andreas Schneider
<[email protected]> írta:
Am 02.10.25 um 13:02 schrieb Richard Shann:
On Wed, 2025-10-01 at 19:49 +0200, Andreas Schneider wrote:
Am 01.10.25 um 14:05 schrieb Richard Shann:
On Tue, 2025-09-30 at 20:26 +0200, Andreas Schneider wrote:
Richard, can you please apply the patch from
http://deb.debian.org/debian/pool/main/d/denemo/denemo_2.6.39-03.debian.tar.xz
    to make Denemo compile with recent libevince? You can
also find
it

Hmm, I get an error trying to build with this,

../src/source/proof.c:283: undefined reference to
`EV_DOCUMENT_ANNOTATIONS'

Is this something not in the atril headers or is it a version
matter?

Have you installed the libatrildocument-dev package?

well,
dpkg-query -l yields

ii  libatrildocument-dev                         1.26.0-
2+deb12u3                     amd64        MATE document
rendering library (development files)

and I see that the inclusion of
libdocument/ev-document-annotations.h
is missing in atril-document.h so this seems to be a bug in
libatrildocument.dev

To work around this bug I propose the attached patch. I'll apply
this
unless there are objections.

Thank you very much, the patch looks good, and it enables me to
compile successfully with libevince.

When I try to compile with --disable-evince --enable-atril, I get
the error

pageturner.c:28:10: fatal error: evince-view.h: Datei oder
Verzeichnis nicht gefunden
   28 | #include <evince-view.h>
      |          ^~~~~~~~~~~~~~~
compilation terminated.

It seems the constant USE_ATRIL is not defined correctly. What have
I made wrong?

Andreas






Reply via email to