On Sun, 2025-11-09 at 19:28 +0100, Andreas Schneider wrote:
> Am 09.11.25 um 16:50 schrieb Richard Shann:
> > I've just installed the changes to configure.ac as part of merging
> > in
> > the work on the Command Center and I see that it no longer builds
> > on my
> > system. (Building on Debian Bookworm with atril and libatrildev
> > installed but no evince packages.)
> > The link step ends with
> > /usr/bin/ld: core/menusystem.o:(.data.rel.ro+0x2f08): undefined
> > reference to `display_printhistory'
> > collect2: error: ld returned 1 exit status
> > make[2]: *** [Makefile:1161: denemo] Error 1
> > make[2]: Leaving directory '/home/rshann/git-denemo/denemo/src'
> > make[1]: *** [Makefile:638: all-recursive] Error 1
> > make[1]: Leaving directory '/home/rshann/git-denemo/denemo'
> > make: *** [Makefile:547: all] Error 2
> >
> > and tracking back I see that it is a set of files in the printview
> > and
> > source directories that are not being included -
> >
> > The relevant bit of Makefile.in would seem to be
> > @HAVE_EVINCE_TRUE@am__append_1 = \
> > @HAVE_EVINCE_TRUE@ source/source.c \
> > @HAVE_EVINCE_TRUE@ source/source.h \
> > @HAVE_EVINCE_TRUE@ source/proof.c \
> > @HAVE_EVINCE_TRUE@ source/proof.h \
> > @HAVE_EVINCE_TRUE@ printview/markupview.h \
> > @HAVE_EVINCE_TRUE@ printview/markupview.c \
> > @HAVE_EVINCE_TRUE@ printview/printview.h \
> > @HAVE_EVINCE_TRUE@ printview/printview.c
> >
> > while the relevant bit of Makefile.am would seem to be
> > if HAVE_EVINCE
> > denemo_SOURCES += \
> > source/source.c \
> > source/source.h \
> > source/proof.c \
> > source/proof.h \
> > printview/markupview.h \
> > printview/markupview.c \
> > printview/printview.h \
> > printview/printview.c
> > endif
> >
> > I've attached the output of the make step, only the svgview.c file
> > in
> > the directory printview is compiled.
>
> I'm facing the same problem. I guess that the relevant files should
> be
> included if HAVE_EVINCE *or* HAVE_ATRIL is defined.
>
> Andreas
>
Yes, it looks like it. This patch to svgview.c enables a default build
on my machine:
diff --git a/src/printview/svgview.c b/src/printview/svgview.c
index 5b9381e25..ef81772a5 100644
--- a/src/printview/svgview.c
+++ b/src/printview/svgview.c
@@ -35,9 +35,11 @@
#ifndef USE_EVINCE
+#ifndef USE_ATRIL
void set_continuous_typesetting (gboolean setting){return FALSE;}
gboolean continuous_typesetting () {return FALSE;}
#endif
+#endif
static gint changecount = -1; //changecount when the playback typeset was
last created
static gboolean RightButtonPressed = FALSE;
Jeremiah - shall I commit this to git?
Richard
