> <>Shreyas Kaushik wrote: > > Attached is the new patch and answesr are inline. > > > > Daniel John Debrunner wrote:
>I got the patch to apply and am running tests on it. > > > 9 (possibly with one unrelated failure) tests fail or have changed output with this patch. Most of the differences in the output seem to be a change in the reporting of the failing column to include the implicit schema name, e.g. T1.C1 is replaced by APP.T1.C1 in an error message. However, there are a few troublesome diffs. The dml162 test from the nist suite fails to create a view that previously was created ok. This dml162 issue would need to be resolved before the patch could be accepted. In addition there are no additional, new, test cases that show the change in behaviour to demostrate that Derby-18 is indeed fixed. Test cases can be added to existing tests. Again, like the identifier change, if a patch from a contibutor causes the tests to "fail" due to modified but correct output, who should be fixing up the test masters? I'd assume the contributor. Dan.
