Submitted this patch. Thanks for applying all (well... most) of the
review comments. Couple of minor comments.
- Derby doesn't support TINYINT datatype. Bind code in
TernaryOperatorNode is checking for this type.
- Method names haven't been changed to reflect Dan's suggestion. I
will let you two fight it out on that.
:-)
Satheesh
Sending java\engine\org\apache\derby\iapi\reference\SQLState.java
Sending
java\engine\org\apache\derby\iapi\sql\compile\C_NodeTypes.java
Sending
java\engine\org\apache\derby\iapi\types\DateTimeDataValue.java
Sending java\engine\org\apache\derby\iapi\types\SQLDate.java
Sending java\engine\org\apache\derby\iapi\types\SQLTime.java
Sending java\engine\org\apache\derby\iapi\types\SQLTimestamp.java
Sending
java\engine\org\apache\derby\impl\sql\compile\NodeFactoryImpl.java
Sending
java\engine\org\apache\derby\impl\sql\compile\TernaryOperatorNode.java
Sending
java\engine\org\apache\derby\impl\sql\compile\sqlgrammar.jj
Sending java\engine\org\apache\derby\loc\messages_en.properties
Adding
java\testing\org\apache\derbyTesting\functionTests\master\timestampArith.out
Sending
java\testing\org\apache\derbyTesting\functionTests\suites\derbylang.runall
Adding
java\testing\org\apache\derbyTesting\functionTests\tests\lang\timestampArith.java
Transmitting file data .............
Committed revision 178061.
Jack Klebanoff wrote:
Satheesh
Bandaram wrote:
Jack, this patch submitted on Friday is
already not based on latest codeline... Shreyas's patch seems to have
modified couple of files you changed. Can you submit an updated patch,
that I will commit quickly, unless anyone else has comments on this
patch.
Satheesh
OK. I integrated my changes with the latest revisions. The resulting
patch is attached. It has passed the derbylang suite. Svn status is
M
java/engine/org/apache/derby/impl/sql/compile/NodeFactoryImpl.java
M
java/engine/org/apache/derby/impl/sql/compile/TernaryOperatorNode.java
M java/engine/org/apache/derby/impl/sql/compile/sqlgrammar.jj
M java/engine/org/apache/derby/iapi/sql/compile/C_NodeTypes.java
M java/engine/org/apache/derby/iapi/types/DateTimeDataValue.java
M java/engine/org/apache/derby/iapi/types/SQLDate.java
M java/engine/org/apache/derby/iapi/types/SQLTime.java
M java/engine/org/apache/derby/iapi/types/SQLTimestamp.java
M java/engine/org/apache/derby/iapi/reference/SQLState.java
M java/engine/org/apache/derby/loc/messages_en.properties
A
java/testing/org/apache/derbyTesting/functionTests/tests/lang/timestampArith.java
A
java/testing/org/apache/derbyTesting/functionTests/master/timestampArith.out
M
java/testing/org/apache/derbyTesting/functionTests/suites/derbylang.runall
Jack Klebanoff
|
