[ 
http://issues.apache.org/jira/browse/DERBY-31?page=comments#action_12313258 ] 

Oyvind Bakksjo commented on DERBY-31:
-------------------------------------

Here is an implementation of Statement.setQueryTimeout.

The patch includes a new functional test in the jdbcapi testsuite.

It is my first Derby patch, so I ask any reviewer; please, use your magnifying 
glass and be critical. :)

May I suggest that Dan looks at it, since he has given me the most feedback on 
this issue? (I don't write this to exclude other volunteers, I just think that 
Mr. "Someone" already has enough on his todo list, given all the requests of 
the kind "Can someone review this patch?". ;o)

Notes/thoughts/issues:
* Perhaps other ResultSet classes than [Bulk]TableScanResultSet should check 
for cancellation, but I think these are the most important ones to begin with. 
I will look into this later.
* Currently, no kind of substatement execution has any timeout value set. This 
includes update operations on updatable resultsets, triggers, alter table 
operations etc.
* To a certain extent, I have cleaned up javadoc warnings in the files touched 
by me, since they made it difficult for me to see whether I had introduced any 
new javadoc warnings myself.

I'm running derbyall and will attach the results once it's finished.

> Statement.setQueryTimeout() support.
> ------------------------------------
>
>          Key: DERBY-31
>          URL: http://issues.apache.org/jira/browse/DERBY-31
>      Project: Derby
>         Type: New Feature
>   Components: JDBC
>  Environment: ALL
>     Reporter: Ali Demir
>     Assignee: Oyvind Bakksjo
>  Attachments: Derby-31.patch, QueryTimer.java, svn.diff, svn.status
>
> Calling Statement.setQueryTimeout() throws exception saying that function is 
> not supported. This is an important JDBC feature and is limiting our options 
> to use Derby with our JDBC code. Implementing this JDBC function would make 
> Derby much easier to adopt.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to