It appears the XID is different for different runs. I had assumed this would be an invariant, but it's not.

This has convinced me that I should pull away from using a master file to verify the correct format of the ids. Instead I will write a new test that does this verification.

For now, however, I am providing a patch that reverts miscerrors.sql and miscerrors.out to their previous form. I will create a new JIRA id to add a test to verify that the format of the connection string is correct.

I ran this against lang/miscerrors.sql and it passes. I did not see that it was necessary to run derbyall, as this is a very localized bug in a single test. It would be great if the committer verifies miscerrors.sql passes for them too prior to checkin.

Thanks,

David

Myrna van Lunteren wrote:

Hi,
lang/miscerrors failed, at least with 189787 (see http://www.multinet.no/~solberg/public/Apache/Derby/index.html/testSummary-189787.html <http://www.multinet.no/~solberg/public/Apache/Derby/index.html/testSummary-189787.html>) Interestingly, our nightlies showed a different diff (build 189872), but still the test fails... Anyone thinks this might be related to their check-in/commit? diff1 (our run, build :
-------------------------
35 del
< xxxxxxFILTERED-TIMESTAMPxxxxx|main,5,main |92 |0 | wombat | null |Cleanup action starting
36 del
< xxxxxxFILTERED-TIMESTAMPxxxxx|main,5,main |92 |0 | wombat | null |Failed Statement is: --
37 del
< xxxxxxFILTERED-TIMESTAMPxxxxx|main,5,main |97 |0 | wombat | null |Cleanup action starting
38 del
< xxxxxxFILTERED-TIMESTAMPxxxxx|main,5,main |97 |0 | wombat | null |Failed Statement is: create table a (one int, two int)
39 del
< xxxxxxFILTERED-TIMESTAMPxxxxx|main,5,main |100 |0 | wombat | null |Cleanup action starting
40 del
< xxxxxxFILTERED-TIMESTAMPxxxxx|main,5,main |100 |0 | wombat | null |Failed Statement is: create table a (one int)
40a35,40
> xxxxxxFILTERED-TIMESTAMPxxxxx|main,5,main |91 |0 | wombat | null |Cleanup action starting > xxxxxxFILTERED-TIMESTAMPxxxxx|main,5,main |91 |0 | wombat | null |Failed Statement is: -- > xxxxxxFILTERED-TIMESTAMPxxxxx|main,5,main |96 |0 | wombat | null |Cleanup action starting > xxxxxxFILTERED-TIMESTAMPxxxxx|main,5,main |96 |0 | wombat | null |Failed Statement is: create table a (one int, two int) > xxxxxxFILTERED-TIMESTAMPxxxxx|main,5,main |99 |0 | wombat | null |Cleanup action starting > xxxxxxFILTERED-TIMESTAMPxxxxx|main,5,main |99 |0 | wombat | null |Failed Statement is: create table a (one int)
Test Failed.
-------------------------
sun run, diff build 189787:
-------------------------
35,40d34
< xxxxxxFILTERED-TIMESTAMPxxxxx|main,5,main |92 |0 | wombat | null |Cleanup action starting < xxxxxxFILTERED-TIMESTAMPxxxxx|main,5,main |92 |0 | wombat | null |Failed Statement is: -- < xxxxxxFILTERED-TIMESTAMPxxxxx|main,5,main |97 |0 | wombat | null |Cleanup action starting < xxxxxxFILTERED-TIMESTAMPxxxxx|main,5,main |97 |0 | wombat | null |Failed Statement is: create table a (one int, two int) < xxxxxxFILTERED-TIMESTAMPxxxxx|main,5,main |100 |0 | wombat | null |Cleanup action starting < xxxxxxFILTERED-TIMESTAMPxxxxx|main,5,main |100 |0 | wombat | null |Failed Statement is: create table a (one int)
Test Failed.
Index: 
java/testing/org/apache/derbyTesting/functionTests/tests/lang/miscerrors.sql
===================================================================
--- 
java/testing/org/apache/derbyTesting/functionTests/tests/lang/miscerrors.sql    
    (revision 190034)
+++ 
java/testing/org/apache/derbyTesting/functionTests/tests/lang/miscerrors.sql    
    (working copy)
@@ -29,5 +29,3 @@
 -- set isolation to repeatable read
 set isolation serializable;
 
--- Print the output of the ErrorLogVTI, make sure it's valid
-SELECT * FROM new org.apache.derby.diag.ErrorLogReader() vti;
Index: java/testing/org/apache/derbyTesting/functionTests/master/miscerrors.out
===================================================================
--- java/testing/org/apache/derbyTesting/functionTests/master/miscerrors.out    
(revision 190034)
+++ java/testing/org/apache/derbyTesting/functionTests/master/miscerrors.out    
(working copy)
@@ -28,14 +28,4 @@
 ij> -- set isolation to repeatable read
 set isolation serializable;
 0 rows inserted/updated/deleted
-ij> -- Print the output of the ErrorLogVTI, make sure it's valid
-SELECT * FROM new org.apache.derby.diag.ErrorLogReader() vti;
-TS                        |THREADID                                |XID        
    |LCCID          |DATABASE                                                   
                                                                     |DRDAID    
                                        |LOGTEXT                                
                                                                                
         
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
-xxxxxxFILTERED-TIMESTAMPxxxxx|main,5,main                             |92      
       |0              | wombat                                                 
                                                                        | null  
                                           |Cleanup action starting             
                                                                                
            
-xxxxxxFILTERED-TIMESTAMPxxxxx|main,5,main                             |92      
       |0              | wombat                                                 
                                                                        | null  
                                           |Failed Statement is: --             
                                                                                
            
-xxxxxxFILTERED-TIMESTAMPxxxxx|main,5,main                             |97      
       |0              | wombat                                                 
                                                                        | null  
                                           |Cleanup action starting             
                                                                                
            
-xxxxxxFILTERED-TIMESTAMPxxxxx|main,5,main                             |97      
       |0              | wombat                                                 
                                                                        | null  
                                           |Failed Statement is: create table a 
(one int, two int)                                                              
            
-xxxxxxFILTERED-TIMESTAMPxxxxx|main,5,main                             |100     
       |0              | wombat                                                 
                                                                        | null  
                                           |Cleanup action starting             
                                                                                
            
-xxxxxxFILTERED-TIMESTAMPxxxxx|main,5,main                             |100     
       |0              | wombat                                                 
                                                                        | null  
                                           |Failed Statement is: create table a 
(one int)                                                                       
            
 ij> 

Reply via email to