[ http://issues.apache.org/jira/browse/DERBY-273?page=comments#action_12313361 ]
Tomohito Nakayama commented on DERBY-273: ----------------------------------------- I read code org.apache.derby.impl.drda.Database#close(); http://svn.apache.org/repos/asf/incubator/derby/code/trunk/java/drda/org/apache/derby/impl/drda/Database.java Documentation comment for this method said "Close the connection and clean up the statement table.". Reading the code , I found there are next processing 1:if stmtTable exists, call every DRDAStatement.close() in stmtTable. 2:if conn exists 2-1:call conn.rollback() 2-2:call conn.close(). If exception happens in conn.rollback() of 2-1 , conn.close() of 2-2 would be not called as Kathey suggested in previous mail. http://mail-archives.apache.org/mod_mbox/db-derby-dev/200506.mbox/[EMAIL PROTECTED] I think conn.close() should be called in finally clause in this method. > The derbynet/dataSourcePermissions_net.java test fails intermittently > --------------------------------------------------------------------- > > Key: DERBY-273 > URL: http://issues.apache.org/jira/browse/DERBY-273 > Project: Derby > Type: Bug > Environment: 1.4.2 JVM (both Sun and IBM) > Reporter: Jack Klebanoff > Assignee: Tomohito Nakayama > > The test fails in the derbyall/derbynetclientmats/derbynetmats suite stack > with the following diff: > *** Start: dataSourcePermissions_net jdk1.4.2 DerbyNetClient > derbynetmats:derbynetmats 2005-05-11 04:24:11 *** > 17a18,19 > > org.apache.derby.iapi.services.context.ShutdownException: > > agentThread[DRDAConnThread_2,5,derby.daemons] > Test Failed. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
