[ http://issues.apache.org/jira/browse/DERBY-382?page=comments#action_12314636 ]
Kathy Saunders commented on DERBY-382: -------------------------------------- I reviewed functions. data types and expressions. All of my comments refer to the page numbers on a printed version of the PDF. Page 72: Keep the list of built-in fuctions in alphabetical order to match the later writeups. So, LENGTH should be moved. Concatenation and CASE expressions are not functions. The correct place is probably expressions. Change CURRENT_DATE to CURRENT_DATE or CURRENT DATE Add CURRENT SCHEMA to the list Change CURRENT_TIME to CURRENT_TIME or CURRENT TIME Change CURRENT_TIMESTAMP to CURRENT_TIMESTAMP or CURRENT TIMESTAMP Page 73: The aggregates section has been mixed in with the functions section. They should be seprate. So, there should be a section called Built-in funtions with the list that is on page 72 and 73, followed by all of the writeups on each function. Then, you should have a separate section called aggregates with the overview on that, followed by the individual writeups on each aggregate. The table on page 73 has characters in cells that should be blank. Page 74: Move AVG writeup to aggregate section Page 81: Move COUNT writeup to aggregate section Page 82: Move COUNT(*) writeup to aggregate section. Page 90: Move MAX writeup to aggregate section. Page 91: Move MIN writeup to aggregate section. Page 95: Move SUM writeup to aggregate section. Page 99: Change the paragraph under Buil-In system procedures to something like the following: Some built-in procedures are not compatible with standard SQL syntax use by other relational databases. These procedures can only be used with Derby. Page 109: Put the list in alphabetical order to match the writeups. So, CHAR FOR BIT DATA, VARCHAR FOR BIT DATA, LONG VARCHAR FOR BIT DATA are out of order Add BLOB, CLOB and VARCHAR to the list of data types. Change DOUBLE PRECISION to be DOUBLE PRECISION or DOUBLE Page 127: Table needs cleaning up > Doc Review: Derby Reference Manual > ---------------------------------- > > Key: DERBY-382 > URL: http://issues.apache.org/jira/browse/DERBY-382 > Project: Derby > Type: Improvement > Components: Documentation > Environment: all > Reporter: Jeff Levitt > Priority: Minor > Fix For: 10.1.1.0 > > This issue tracks comments for the Derby Reference Manual. The deadline for > posting comments is Tuesday, June 28, noon Pacific time. > Some guidelines to follow when posting comments to this issue are: > - Try to make clear and concise comments about what you want changed whenever > possible. Provide concrete comments that say "Please change <original> to > <modified>" instead of generic comments like "This section needs to be > rewritten." > - If you're reviewing the HTML Files copy, include the URL for the page in > the review comment. Obtain the URL like this: > * highlight the topic in the left frame > * right click > * choose "Properties" > * copy and paste the address in the pop up box. > - If you're reviewing the PDF copy, in the review comment: > * Include the page number for the PDF, and indicate whether the number is > the PDF sheet number or the printed page number. > * Include the title of the section that the problem occurs in. If it's in > a subsection, try to include the hierarchy of titles. > - Please don't review the HTML Book copy -- it'll be time consuming to match > up that copy with the underlying DITA source. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
