Tomohito Nakayama (JIRA) wrote: > [ > http://issues.apache.org/jira/browse/DERBY-496?page=comments#action_12320680 > ] > > Tomohito Nakayama commented on DERBY-496: > ----------------------------------------- > > Description of DERBY-496_2_addition.patch: > > Modification: > * Adding DiagnosticUtil explicitly to derby.jar by modifying > extraDBMSclasses.properties > > Testing: > * unit/T_Diagnosticable passed.
Not sure I agree with this change. Adding code into the product (derby.jar) *only* in order to make a unit test pass seems a generally incorrect approach. I think that maybe the Diagnosticable interface should be removed. I think the functionality it is trying to provide is really the domain of a Java debugger. The classes & mechanism were there to provide access to non-public fields of classes for debugging, but its approach requires security compromises to be made, by making such private or non-public fields accessible. Dan.
