Daniel John Debrunner wrote:
Deepa Remesh wrote:
On 8/31/05, Philip Wilder <[EMAIL PROTECTED]> wrote:
You did mention that the use of the Driver Manager was
problematic. The only reason that I use the DriverManager is so that I
can make use of the "jdbc:default:connection" rather then establishing a
new Connection. If you (or anyone else) knows a way in which I can do
this in a J2ME friendly manner then our problem is solved. If not, I can
take a closer look at my code and see how an additional Connection would
affect operation.
I have changed the connection to use EmbeddedSimpleDataSource. So the
procedure does not use nested connection and there is an additional
connection. I am running tests with this change. I hope this is okay
for the test.
I would hesitate to make that change, procedures in general should be
using nested connections, use of another connection can lead to
deadlocks etc. The issue is that there is a chance people take test code
as an example of the correct way to write a procedure, and incorrectly
assume that use of EmbeddedSimpleDataSource does return a nested
connection. It may be better to move the test case to another test.
Dan.
I guess then we have three options:
1) Make the changes Deepa proposes with a "do as I say and not as I do
comment" about the incorrect format of the procedure. This is probably
not a trend we want to start but I mention it for the sake of argument.
2) Move Deepa's test elsewhere to a J2ME friendly local.
3) Move (some) of the tests added for DERBY-213. Both Procedures and
CallableStatements are new comers to the jdbcapi/resultset.java tests
and they are causing the problem. Looking for potential spots to move
these tests I see that derbynet/callablestatement.java has promise but I
suspect these tests are exclusive to Derby client drivers and it would
be beneficial to test embedded as well. I didn't see any other
particularly tempting locations and I hardly think that these two tests
warrent the creation of a new test file.
So if anyone has any comments or counter proposals I'm all ears.
Philip
