[ http://issues.apache.org/jira/browse/DERBY-375?page=comments#action_12332124 ]
Kathey Marsden commented on DERBY-375: -------------------------------------- Reviewed and committed this patch to the trunk. Looks good. Thanks for fixing DERBY-613 too! My only comment would be that perhaps it would be better to use a substitute to something generic rather than a delete of the traceDirectory lines. If you feel so motivated you could submit a followon patch. Date: Fri Oct 14 18:22:15 2005 New Revision: 321274 URL: http://svn.apache.org/viewcvs?rev=321274&view=rev > Specification of incomplete server properties on command line causes NPE with > NetworkServerControl when starting the server. > ---------------------------------------------------------------------------------------------------------------------------- > > Key: DERBY-375 > URL: http://issues.apache.org/jira/browse/DERBY-375 > Project: Derby > Type: Bug > Components: Network Server > Versions: 10.1.1.0, 10.2.0.0 > Environment: Running Derby Network Server and using command line API to > start the server. > Reporter: A B > Assignee: Deepa Remesh > Fix For: 10.2.0.0 > Attachments: derby-375.diff, derby-375.status, derbyall_report.txt > > When using the command line to start the Network Server, there a couple of > cases where if a property is specified on the command line but no value is > given (ex. "-Dderby.drda.maxThreads" instead of "-Dderby.drda.maxThreads=3"), > a Null Pointer Exception will result, when the correct behavior should be to > use some kind of default. > For example: > > java -Dderby.drda.maxThreads org.apache.derby.drda.NetworkServerControl > > start -p 1528 > java.lang.NullPointerException > at > org.apache.derby.impl.drda.NetworkServerControlImpl.localizeMessage(NetworkServerControlImpl.java) > at > org.apache.derby.impl.drda.NetworkServerControlImpl.consolePropertyMessageWork(NetworkServerControlImpl.java) > at > org.apache.derby.impl.drda.NetworkServerControlImpl.consolePropertyMessage(NetworkServerControlImpl.java) > at > org.apache.derby.impl.drda.NetworkServerControlImpl.getIntPropVal(NetworkServerControlImpl.java) > at > org.apache.derby.impl.drda.NetworkServerControlImpl.getPropertyInfo(NetworkServerControlImpl.java) > at > org.apache.derby.impl.drda.NetworkServerControlImpl.<init>(NetworkServerControlImpl.java) > at > org.apache.derby.drda.NetworkServerControl.main(NetworkServerControl.java) > Note that even though we see this NPE, it appears that the server still > starts up, although the startup may not be complete (subsequent attempts to > connect might lead to errors like "Invalid reply from network server: > Insufficient data."). > For other properties, this will just result in the default value being used, > which is the correct behavior. For example: > > java -Dderby.drda.host org.apache.derby.drda.NetworkServerControl start -p > > 1528 > Server is ready to accept connections on port 1528. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
