Why yes it is, thanks. I remove my suggestion.
David
Daniel John Debrunner wrote:
David W. Van Couvering wrote:
I like to start by applying a patch to the revision level that the patch
was built with. That way I can make very sure I applied things
correctly -- I can diff the output of svn status and svn diff with what
the contributor provided. This is especially important when the
contribution includes files that are added (especially new empty files
like empty test master files), which I actually have to add by hand.
Once that looks good, I do an svn update with no -r option to update the
tree to the head of the trunk. If at this point I get errors, then,
yes, I would complain to the contributor, but I want to make sure I
applied the patch correctly first.
Maybe that's not how everyone does it, but that's how I like to do it,
so that's why I was suggesting the revision number. I can also do it by
date, but the revision number is more accurate.
Ok sounds fine, isn't the svn revision in the svn diff output though?
Dan.
begin:vcard
fn:David W Van Couvering
n:Van Couvering;David W
org:Sun Microsystems, Inc.;Database Technology Group
email;internet:[EMAIL PROTECTED]
title:Senior Staff Software Engineer
tel;work:510-550-6819
tel;cell:510-684-7281
x-mozilla-html:TRUE
version:2.1
end:vcard
