Andreas Korneliussen wrote: > Daniel John Debrunner wrote: >> Though maybe the patch does allow positioned updates on 'SELECT * FROM >> T' if the JDBC result set is updateable? If that's the case, then some >> additional tests should be added. >> > > The patch does allow positioned updates on 'SELECT * FROM T' if the > concurrency mode is set to CONCUR_UPDATABLE > > This is tested implicitly by the fact that the JDBC driver uses > positioned updates when doing updateRow(). It produces statements like: > "update table T set ... where current of SQLCUR0". Positioned updates > is therefore tested in the jdbc/updateableResultSet.java test.
Implicit testing is not ideal. This means we are testing a user visible feature only through a specific implementation. If someone improved the JDBC updateable result set implementation to not use positioned updates or deletes then unless more testing was added we would have a testing hole. Dan.
