[ 
https://issues.apache.org/jira/browse/DERBY-6264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13684252#comment-13684252
 ] 

Bryan Pendleton commented on DERBY-6264:
----------------------------------------

Here are a number of possibilities we should consider:

1) Perhaps the other 4 methods in PropertyInfo are unused and unwanted. Then
   we should remove those methods from the class, and just leave 
SetDatabaseProperty
2) Perhaps the other 4 methods in PropertyInfo are useful, but aren't currently
   very accessible. Perhaps we should add additional methods into the system 
procedures,
   mimicing http://db.apache.org/derby/docs/10.10/ref/rrefsetdbpropproc.html so 
that
   applications can access those methods
3) Perhaps the other 4 methods in PropertyInfo are useful, and can be called 
just as is,
   possibly from a trigger or other server-side JDBC call. If so, we should 
figure out how
   to add test cases for those methods so that we have test coverage

Regarding TestPropertyInfo, the following possibilities come to mind:
1) Perhaps this class is wholly unnecessary, and should be removed
2) Perhaps this class is in fact invoked by our current regression test suites,
   and I just don't understand how.
3) If the class is useful, it should presumably be converted to a JUnit test and
   run in our JUnit test suites
4) Should the class somehow subclass the PropertyInfo class, as the
   comment implies?
                
> Improve test coverage of org.apache.derby.iapi.db.PropertyInfo
> --------------------------------------------------------------
>
>                 Key: DERBY-6264
>                 URL: https://issues.apache.org/jira/browse/DERBY-6264
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Test
>            Reporter: Bryan Pendleton
>            Assignee: ahsan shamsudeen
>            Priority: Minor
>
> According to the coverage reports, only 1 of the 5 methods in
> org.apache.derby.iapi.db.PropertyInfo is exercised by the Derby
> regression tests.
> This sub-task is to improve that test coverage.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to