[ http://issues.apache.org/jira/browse/DERBY-614?page=comments#action_12358655 ]
Kathey Marsden commented on DERBY-614: -------------------------------------- The change looks good to me. A couple small points and a request.... For the assertion "There was no data to split", it would be good to have something a bit more descriptive. Can the Jira614.java test be added to an existing test like prepStmt.java to avoid additional database creation in the test suite? Would you be willing to try your server with the original 10.1 client release?Probably the easiest thing to do is run derbynetclientmats with the derbyTesting.jar and derbyclient.jar from the 10.1.1.0 release and your 10.2 derby.jar and derbynet.jar. There may be a few diffs because of bug fixes in 10.2. If you post the diffs I'd be happy to spot check if they just look like bugfixes. Other thoughts that came to mind upon reviewing this change, but not directly relevant to the fix: Even though the agent errors are essentially assertions it might be good to file a Jira entry to localize them, since we do not put them in SanityManager.DEBUG blocks and they could be returned to the user. Since splitting is expensive, it might it be good for network server to be a bit smarter about the split by either improving the coarse estimation in writeQRYDTA or doing something more efficient to handle the overrun than copying it into a new array. Of course that may make bugs like this even harder to track down. > Execution failed because of a Distributed Protocol Error > -------------------------------------------------------- > > Key: DERBY-614 > URL: http://issues.apache.org/jira/browse/DERBY-614 > Project: Derby > Type: Bug > Components: Network Server > Versions: 10.1.1.0 > Environment: Linux 2.4, Sun JDK 1.4.2_07, full SYSINFO will be attached. > Reporter: Bryan Pendleton > Attachments: clientSideTrace.txt, clientStack.txt, > derby-614-with-tests.diff, derby-614.stat, derby-614.zip, derbyTrace.txt, > query.txt, serverSideTrace.txt, spec.html, sysinfo.derby > > I am intermittently receiving Distributed Protocol Error exceptions in my > client code. Simultaneously, > my derby.log is recording Distributed Protocol Error exceptions on the server > side. > I cannot reliably reproduce this problem. > However, the problem always occurs in the same section of my application, so > I can at least > describe that section of my application. (I'll do so in an attachment). > Here is the error I receive on the server side. Sometimes, the CODPNT is 2116 > and the > Error Code Value is 1d, rather than 2114 and e. > 2005-10-05 02:10:23.663 GMT Thread[DRDAConnThread_2,5,main] (DATABASE = > BuildFar > m), (DRDAID = GA0A0026.P7E6-4182154075488704215{136532}), Execution failed > becau > se of a Distributed Protocol Error: DRDA_Proto_SYNTAXRM; CODPNT arg = 2114; > Er > ror Code Value = e > Execution failed because of a Distributed Protocol Error: > DRDA_Proto_SYNTAXRM; > CODPNT arg = 2114; Error Code Value = e > 2005-10-05 02:10:23.663 GMT Thread[DRDAConnThread_2,5,main] (DATABASE = > BuildFar > m), (DRDAID = GA0A0026.P7E6-4182154075488704215{136532}), null > null > org.apache.derby.impl.drda.DRDAProtocolException > at org.apache.derby.impl.drda.DRDAConnThread.throwSyntaxrm(Unknown > Sourc > e) > at org.apache.derby.impl.drda.DRDAConnThread.missingCodePoint(Unknown > So > urce) > at org.apache.derby.impl.drda.DRDAConnThread.parseCNTQRY(Unknown > Source) > at org.apache.derby.impl.drda.DRDAConnThread.splitQRYDTA(Unknown > Source) > at org.apache.derby.impl.drda.DRDAConnThread.writeFDODTA(Unknown > Source) > at org.apache.derby.impl.drda.DRDAConnThread.writeQRYDTA(Unknown > Source) > at org.apache.derby.impl.drda.DRDAConnThread.processCommands(Unknown > Sou > rce) > at org.apache.derby.impl.drda.DRDAConnThread.run(Unknown Source) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
