[ http://issues.apache.org/jira/browse/DERBY-499?page=all ]
Rick Hillegas updated DERBY-499:
--------------------------------
Attachment: bug499.diff
This patch (bug499.diff) enables the BOOLEAN datatype as described in the
functional
spec (BooleanFS.html). On my machine, this patch passes the derbyall
and compatibility suite tests. This patch affects the following files:
M java/engine/org/apache/derby/impl/sql/compile/sqlgrammar.jj
A java/engine/org/apache/derby/iapi/reference/DRDAConstants.java
M java/drda/org/apache/derby/impl/drda/FdocaConstants.java
M java/drda/org/apache/derby/impl/drda/SQLTypes.java
M java/drda/org/apache/derby/impl/drda/EXTDTAInputStream.java
M java/drda/org/apache/derby/impl/drda/NetworkServerControlImpl.java
M java/drda/org/apache/derby/impl/drda/DRDAConnThread.java
M java/drda/org/apache/derby/impl/drda/AppRequester.java
M
java/testing/org/apache/derbyTesting/functionTests/tests/lang/db2Compatibility.sql
A java/testing/org/apache/derbyTesting/functionTests/tests/junitTests/lang
A
java/testing/org/apache/derbyTesting/functionTests/tests/junitTests/lang/BooleanTest.java
A
java/testing/org/apache/derbyTesting/functionTests/tests/junitTests/lang/default_app.properties
A
java/testing/org/apache/derbyTesting/functionTests/tests/junitTests/lang/LangSuite.java
A
java/testing/org/apache/derbyTesting/functionTests/tests/junitTests/lang/build.xml
M
java/testing/org/apache/derbyTesting/functionTests/tests/junitTests/compatibility/CompatibilitySuite.java
M
java/testing/org/apache/derbyTesting/functionTests/tests/junitTests/compatibility/testScript.xml
M
java/testing/org/apache/derbyTesting/functionTests/tests/junitTests/compatibility/JDBCDriverTest.java
M
java/testing/org/apache/derbyTesting/functionTests/master/db2Compatibility.out
M
java/testing/org/apache/derbyTesting/functionTests/master/implicitConversions.out
M
java/testing/org/apache/derbyTesting/functionTests/master/DerbyNetClient/metadata.out
M
java/testing/org/apache/derbyTesting/functionTests/master/DerbyNetClient/syscat.out
M
java/testing/org/apache/derbyTesting/functionTests/suites/derbylang.runall
M
java/testing/org/apache/derbyTesting/functionTests/util/DerbyJUnitTest.java
M java/testing/build.xml
M java/client/org/apache/derby/client/net/FdocaConstants.java
M java/client/org/apache/derby/client/net/NetConfiguration.java
M java/client/org/apache/derby/client/net/Typdef.java
M java/client/org/apache/derby/client/net/NetStatementRequest.java
M java/client/org/apache/derby/client/am/CrossConverters.java
M java/client/org/apache/derby/client/am/Types.java
M java/client/org/apache/derby/client/am/Cursor.java
M java/client/org/apache/derby/client/am/SignedBinary.java
M java/client/org/apache/derby/client/am/DatabaseMetaData.java
M java/client/org/apache/derby/client/am/ColumnMetaData.java
A brief description of these changes follows:
1) sqlgrammar.jj - Small changes here to enable the BOOLEAN type and
its literals: true, false, and unknown.
2) DRDAConstants.java - This new file holds common definitions of the
DRDA and DB2 datatypes plus Derby's product identifiers. Client and
server code now share these constants. This file adds new DRDA
datatypes for BOOLEAN as well as for other datatypes we may add in
10.2. The Open Group is almost at the point where I can submit
these types for approval.
Note that an additional piece of cleanup can be done later: Right
now, Typdef.java has a long table (environmentTables_) of magic
numbers which are really just the DRDA datatypes. This table should
be scrubbed to use the constants from DRDAConstants.java.
3) AppRequester.java - This server class, which already held product version
info, now reports whether the connected client can handle the new
BOOLEAN datatype.
4) Various other changes to the DRDA network layer to recognize
BOOLEAN and handle it correctly based on the client's capabilities.
5) JDBCDriverTest.java - Additional compatibility tests added to track
assertions from the functional spec.
6) LangSuite.java - A new JUnit suite currently containing one test:
BooleanTest.java. LangSuite itself is wired into the derbylang
suite. I'm thinking that over time, we can migrate existing derbylang
tests into this suite and also wire in new JUnit-based language
tests.
7) BooleanTest.java - SQL tests for the BOOLEAN datatype. These
supplement the JDBC tests for BOOLEAN found in JDBCDriverTest.
8) testScript.xml - Now tracks the trunk/embedded combination on
jdk1.3 and 1.5.
I hope that when this submission is committed, it will be complete
enough that we can use it as a template for adding additional
datatypes (such as XML) to our network layer.
A later submission will address changes to the user docs.
> Expose BOOLEAN datatype to end users
> ------------------------------------
>
> Key: DERBY-499
> URL: http://issues.apache.org/jira/browse/DERBY-499
> Project: Derby
> Type: New Feature
> Components: SQL
> Versions: 10.1.1.0
> Reporter: Rick Hillegas
> Assignee: Rick Hillegas
> Attachments: BooleanFS.html, bug499.diff
>
> Veaceslav Chicu started an email thread on 8 August 2005 titled "boolean
> type". He was disappointed that Derby doesn't support the ansi BOOLEAN
> datatype. On closer inspection, Derby does internally support this type but
> does not expose this support to end users.
> Derby should let users declare table columns of type BOOLEAN. This should be
> an indexable datatype.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
