[ 
https://issues.apache.org/jira/browse/DERBY-3195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Myrna van Lunteren updated DERBY-3195:
--------------------------------------
    Attachment: NetworkServerControl.html
                DERBY-3195.diff
                tadmincbdjhhfd.html
                cadminov825266.html
                DERBY-3195_doc.diff

I am attaching two patches to address this issue.
One patch is for the adminguide - server section, to add that a security 
manager is started when network server is started.
The other patch is for the javadoc of NetworkServerControl, to add comments to 
the summary and start method sections.

I decided not to add details to NetworkServerControl's 'main' method because 
it's only on start that the security manager is installed. 
I decided not to add anything to the derby.drda.startNetworkServer section 
because I believe that when you start Derby it automatically uses a security 
manager - so it's not unexpected that it does the same for network Server.
If a change here is needed I think it makes more sense to add a reference to 
the main section about networkserver, rather than repeat information here.

I could not see a logical way to document anything regarding java -jar. I think 
using java -jar to start the main class identified in the jar's manifest file 
(in this case, NetworkServerControl is listed as the main class in 
derbynet.jar) is default java functionality, and I already changed the 
information re 'start' for NetworkServerControl.

Review will be appreciated.

> Describe if default security manager & policy is installed or not on each of 
> the mechanisms to start the network server.
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3195
>                 URL: https://issues.apache.org/jira/browse/DERBY-3195
>             Project: Derby
>          Issue Type: Improvement
>          Components: Documentation, Javadoc
>    Affects Versions: 10.3.1.4
>            Reporter: Daniel John Debrunner
>            Assignee: Myrna van Lunteren
>            Priority: Minor
>         Attachments: DERBY-3195.diff, DERBY-3195_doc.diff, 
> NetworkServerControl.html, cadminov825266.html, tadmincbdjhhfd.html
>
>
> The explicit mechanisms to start the network server make no mention of if 
> they install a default security manager and policy or not.
> These are at least:
> NetworkServerControl javadoc
>    summary - start command on command line
>    main() method
>    start() method
> derby.drda.startNetworkServerProperty
> Each start mechanism should clearly state if they install or do not install 
> the default security manager and policy.
> (Other starts commands are)
> java -jar derbynet.jar
> java -jar derbyrun.jar server start
> I didn't look to see if these document the default policy or not, not sure 
> where they are documented.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to