[ https://issues.apache.org/jira/browse/DERBY-6945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342677#comment-16342677 ]
Rick Hillegas commented on DERBY-6945: -------------------------------------- Attaching derby-6945-15-aa-moveMoreClientClassesOutOfPublicAPI.diff. This patch moves the remaining, unnecessary client classes out of org.apache.derby.jdbc and into client-internal packages. Tests passed cleanly for me on this patch. Touches the following files: {noformat} --------------------------------------- M java/build/org/apache/derbyBuild/lastgoodjarcontents/insane.derbyclient.jar.lastcontents M java/build/org/apache/derbyBuild/lastgoodjarcontents/sane.derbyclient.jar.lastcontents A + java/client/org/apache/derby/client/ClientConnectionPoolDataSourceInterface.java A + java/client/org/apache/derby/client/ClientXADataSourceInterface.java D java/client/org/apache/derby/jdbc/ClientConnectionPoolDataSourceInterface.java D java/client/org/apache/derby/jdbc/ClientXADataSourceInterface.java Move client classes which are not in the public API out of org.apache.derby.jdbc and into client-internal packages. --------------------------------------- M java/client/org/apache/derby/jdbc/BasicClientConnectionPoolDataSource40.java M java/client/org/apache/derby/jdbc/BasicClientXADataSource40.java M java/client/org/apache/derby/jdbc/ClientConnectionPoolDataSource.java M java/client/org/apache/derby/jdbc/ClientXADataSource.java M java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/ClientConnectionPoolDataSourceTest.java M java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/J2EEDataSourceTest.java Adjust references to the moved classes. {noformat} > Re-package Derby as a collection of jigsaw modules > -------------------------------------------------- > > Key: DERBY-6945 > URL: https://issues.apache.org/jira/browse/DERBY-6945 > Project: Derby > Issue Type: Improvement > Affects Versions: 10.13.1.2 > Reporter: Rick Hillegas > Priority: Major > Attachments: derby-6945-01-aa-remove_derbyPreBuild_dep.diff, > derby-6945-02-ab-newDerbySharedJar.diff, > derby-6945-02-ac-newDerbySharedJar.diff, derby-6945-03-aa-partitionTest.diff, > derby-6945-04-aa-moveRunClass.diff, > derby-6945-05-aa-removeRedundant_Attribute_SQLState.diff, > derby-6945-06-aa-removeOtherSharedDuplicates.diff, > derby-6945-07-aa-net_client_overlap.diff, > derby-6945-08-aa-move_shared_iapi_under_shared.diff, > derby-6945-08-ab-move_shared_iapi_under_shared.diff, > derby-6945-08-ad-move_shared_iapi_under_shared.diff, > derby-6945-09-ab-moveInternalDriver.diff, derby-6945-10-aa-moveDriver42.diff, > derby-6945-11-ab-moveAutoloadedDriver.diff, > derby-6945-12-ab-moveClientDataSourceInterface.diff, > derby-6945-13-aa-create-ClientAutoloadedDriver.diff, > derby-6945-14-aa-moveMoreEmbeddedClassesOutOfPublicAPI.diff, > derby-6945-15-aa-moveMoreClientClassesOutOfPublicAPI.diff, jdeps.out.tar > > > Once we commit to building with Java 9 (see DERBY-6856), we should consider > re-packaging Derby as a set of jigsaw modules. This would result in a > different set of release artifacts. This might be a good opportunity to > address the Tomcat artifactory issues raised by issue DERBY-6944. -- This message was sent by Atlassian JIRA (v7.6.3#76005)