Re: [jira] Updated: (DERBY-326) Improve streaming of large objects for network server and client

[David W. Van Couvering]

Bryan Pendleton wrote:

2) It seems like it might be possible to improve these lines in
   ReEncodedInputStream.java:

        if(reader == null){
            throw new NullPointerException();
        }

        if(enc == null){
            throw new NullPointerException();
        }

   I think it would be better to pass a string to the exception
   constructor, indicating which variable was null, as in:

            throw new NullPointerException(
                "null 'reader' passed to ReEncodedInputStream");


4) In EXTDTAInputStream.openInputStreamLazily, I think it would be
   better to change the line

           throw new IllegalStateException();
to
           throw new IllegalStateException(
               "Either 'blob' or 'clob' must be non-null");


I do hope that these strings are internationalized rather than using 
hardcoded English... :)

begin:vcard
fn:David W Van Couvering
n:Van Couvering;David W
org:Sun Microsystems, Inc.;Database Technology Group
email;internet:[EMAIL PROTECTED]
title:Senior Staff Software Engineer
tel;work:510-550-6819
tel;cell:510-684-7281
x-mozilla-html:TRUE
version:2.1
end:vcard