[ http://issues.apache.org/jira/browse/DERBY-210?page=comments#action_12362711 ]
Bryan Pendleton commented on DERBY-210: --------------------------------------- If I understand your comment correctly, you feel that you now have a correct fix, which avoids the memory leaks; however, you are concerned that there is a performance problem because the tracking of the ResultSet objects in the SectionManager hashtable is in some or all cases unnecessary. In that case, my opinion is that you should commit the correctness fix now, and file the performance issue as a separate bug and address it separately. I will try to take a closer look at your changes over the next week and I will let you know if I have any other comments. > Network Server will leak prepared statements if not explicitly closed by the > user until the connection is closed > ---------------------------------------------------------------------------------------------------------------- > > Key: DERBY-210 > URL: http://issues.apache.org/jira/browse/DERBY-210 > Project: Derby > Type: Bug > Components: Network Client > Reporter: Kathey Marsden > Assignee: Deepa Remesh > Attachments: derby-210-patch1.diff, derby-210-patch1.status, derbyStress.java > > Network server will not garbage collect prepared statements that are not > explicitly closed by the user. So a loop like this will leak. > ... > PreparedStatement ps; > for (int i = 0 ; i < numPs; i++) > { > ps = conn.prepareStatement(selTabSql); > rs =ps.executeQuery(); > while (rs.next()) > { > rs.getString(1); > } > rs.close(); > // I'm a sloppy java programmer > //ps.close(); > } > > To reproduce run the attached program > java derbyStress > Both client and server will grow until the connection is closed. > > It is likely that the fix for this will have to be in the client. The client > does not send protocol to close the prepared statement, but rather reuses the > PKGNAMCSN on the PRPSQLSTT request once the prepared statement has been > closed. This is how the server knows to close the old statement and create a > new one. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
